Re: [PATCH 13/13] MIPS: jz4740: Remove custom GPIO code

Paul Cercueil
2017-01-20T10:01:35Z

Le 2017-01-19 10:07, Linus Walleij a Ã©crit :

> On Wed, Jan 18, 2017 at 12:14 AM, Paul Cercueil <paul@crapouillou.net>
> wrote:
>
>> All the drivers for the various hardware elements of the jz4740 SoC
>> have been modified to use the pinctrl framework for their pin
>> configuration needs. As such, this platform code is now unused and can
>> be deleted. Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>
> I feel I might have come across as a bit harsh in the previous review
> of the
> patches leading up to this one. In that case I'm sorry.
>
> I can clearly see that the intent of the series is to remove this
> hopelessly
> idiomatic code from the MIPS hurdle, and move these systems over
> to standard frameworks.
>
> In a way, if I look at the kernel as a whole, it would likely look
> better
> after these patches were merged, than before. Even with the
> shortcomings I painted out in the previous review comments.
>
> A very complicated piece of messy code is cut from MIPS.
>
> I think this is very valuable work and well worth persuing, so please
> go ahead and work with the series, your effort is very much
> appreciated!
>
> Yours,
> Linus Walleij

Well thank you for your very constructive criticism ;) And for your
review.
I'll submit a v2 very soon - I don't want to miss the 4.11 merge.

Regards,
-Paul