Re: [PATCH 09/13] mmc: jz4740: Let the pinctrl driver configure the pins

Ulf Hansson
2017-01-19T10:55:41Z

[...]

>
> -#ifdef CONFIG_PM_SLEEP
> -
> -static int jz4740_mmc_suspend(struct device *dev)
> -{
> - struct jz4740_mmc_host *host = dev_get_drvdata(dev);
> -
> - jz_gpio_bulk_suspend(jz4740_mmc_pins, jz4740_mmc_num_pins(host));
> -

Shouldn't this be replaced with a call to:
pinctrl_pm_select_sleep_state();

> - return 0;
> -}
> -
> -static int jz4740_mmc_resume(struct device *dev)
> -{
> - struct jz4740_mmc_host *host = dev_get_drvdata(dev);
> -
> - jz_gpio_bulk_resume(jz4740_mmc_pins, jz4740_mmc_num_pins(host));

Shouldn't this be replaced with a call to:
pinctrl_pm_select_default_state();

[...]

Kind regards
Uffe