From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb
Date: Tue, 20 Jun 2017 20:08:58 +0000 [thread overview]
Message-ID: <20170620200858.GA5287@sudip-laptop> (raw)
In-Reply-To: <CAHp75VdQ0BoKtbr5m--sZH1yHs=Oo-B577VnxoO8E-0jn0QzCA@mail.gmail.com>
On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>
>
> > +#ifdef CONFIG_X86
> > + primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> > + IORESOURCE_ROM_SHADOW;
> > +#endif
>
> Why do we need #ifdef?
It has been done in exactly the same way it is done in drm drivers.
All the drm drivers I have checked uses #ifdef.
See for example:
http://elixir.free-electrons.com/linux/v4.12-rc6/source/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c#L470
If you think #ifdef is not required, please send patch for the drm
drivers, and we follow that change here also.
>
> In any case you may introduce a temporary variable to have pointer to resource
>
> struct resource *res = &pdev->resource[PCI_ROM_RESOURCE];
No, we will not want to do it in a different way than the way it is done
by drm drivers.
--
Regards
Sudip
next prev parent reply other threads:[~2017-06-20 20:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:32 [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee
2017-06-19 20:32 ` [PATCH 2/2] staging: sm750fb: change default screen resolution Sudip Mukherjee
2017-06-19 20:47 ` [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Andy Shevchenko
2017-06-20 20:08 ` Sudip Mukherjee [this message]
2017-06-20 20:20 ` Dan Carpenter
2017-06-20 20:40 ` Andy Shevchenko
2017-06-20 20:44 ` Sudip Mukherjee
2017-06-20 20:41 ` Sudip Mukherjee
2017-06-25 12:43 ` Sudip Mukherjee
2017-06-25 12:54 ` Greg Kroah-Hartman
2017-06-25 13:54 ` Sudip Mukherjee
2017-06-25 14:27 ` Greg Kroah-Hartman
2017-06-25 15:07 ` Sudip Mukherjee
[not found] ` <31608A86C142F84E93092EC1B170B676743012DD@TWMBS01.tw.smi.ad>
2017-06-29 12:57 ` 答复: " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620200858.GA5287@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).