From: Greg KH <gregkh@linuxfoundation.org>
To: Dhananjay Balan <mail@dbalan.in>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: move common locking code to a macro
Date: Wed, 21 Jun 2017 14:35:08 +0000 [thread overview]
Message-ID: <20170621143508.GB14790@kroah.com> (raw)
In-Reply-To: <20170620165013.11013-1-mail@dbalan.in>
On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> The locking and unlocking code used by copy routines is common, so
> moved it to a macro.
Ick, no, never "hide" locks like this, that's not good at all. We want
to see the locks in the code where it happens, otherwise it is not
obvious as to what is going on.
sorry,
greg k-h
prev parent reply other threads:[~2017-06-21 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 16:50 [PATCH] staging: sm750fb: move common locking code to a macro Dhananjay Balan
2017-06-20 20:05 ` Dan Carpenter
2017-06-21 8:59 ` Dhananjay Balan
2017-06-21 9:12 ` Dan Carpenter
2017-06-21 14:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621143508.GB14790@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@dbalan.in \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox