From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb
Date: Sun, 25 Jun 2017 13:54:29 +0000 [thread overview]
Message-ID: <20170625135429.GA8651@sudip-laptop> (raw)
In-Reply-To: <20170625125451.GB2728@kroah.com>
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote:
> > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote:
> > > From: Teddy Wang <teddy.wang@siliconmotion.com>
> > >
> > > If vesafb is enabled in the config then /dev/fb0 is created by vesa
> > > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
> > > effectively work with xorg.
> > > So if it has been alloted fb1, then try to remove the other fb0.
> > >
> > > Signed-off-by: Teddy Wang <teddy.wang@siliconmotion.com>
> > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > > ---
> >
> > Hi Greg,
> > You applied the second patch but not this one. Did I miss any review
> > comments from you about this one?
>
> All of the other complaints about this patch were not sufficient for me
> to justify ignoring it? Why would I not listen to them?
This patch is doing what all the drm drivers are doing. So you want
us to do something completely new rather than following the established
practice of a drm driver?
--
Regards
Sudip
next prev parent reply other threads:[~2017-06-25 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:32 [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee
2017-06-19 20:32 ` [PATCH 2/2] staging: sm750fb: change default screen resolution Sudip Mukherjee
2017-06-19 20:47 ` [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Andy Shevchenko
2017-06-20 20:08 ` Sudip Mukherjee
2017-06-20 20:20 ` Dan Carpenter
2017-06-20 20:40 ` Andy Shevchenko
2017-06-20 20:44 ` Sudip Mukherjee
2017-06-20 20:41 ` Sudip Mukherjee
2017-06-25 12:43 ` Sudip Mukherjee
2017-06-25 12:54 ` Greg Kroah-Hartman
2017-06-25 13:54 ` Sudip Mukherjee [this message]
2017-06-25 14:27 ` Greg Kroah-Hartman
2017-06-25 15:07 ` Sudip Mukherjee
[not found] ` <31608A86C142F84E93092EC1B170B676743012DD@TWMBS01.tw.smi.ad>
2017-06-29 12:57 ` 答复: " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170625135429.GA8651@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).