From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 30 Jun 2017 08:02:42 +0000 Subject: [PATCH] video: fbdev: imxfb: use after free in imxfb_remove() Message-Id: <20170630080242.emnw7l53f52pvzeo@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org We free "info" then dereference it on the next line. I've moved the call to framebuffer_release() down a line to avoid this problem. Fixes: b7d2d37276c1 ("video: imxfb: Remove unused fields from platform data structure") Signed-off-by: Dan Carpenter diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index c166e0725be5..1d0c3592b290 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -1080,10 +1080,9 @@ static int imxfb_remove(struct platform_device *pdev) fb_dealloc_cmap(&info->cmap); kfree(info->pseudo_palette); - framebuffer_release(info); - dma_free_wc(&pdev->dev, fbi->map_size, info->screen_base, fbi->map_dma); + framebuffer_release(info); iounmap(fbi->regs); release_mem_region(res->start, resource_size(res));