From: Lynn Lei <lynnl.yet@gmail.com>
To: sudipm.mukherjee@gmail.com
Cc: teddy.wang@siliconmotion.com, b.zolnierkie@samsung.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning
Date: Tue, 04 Jul 2017 15:24:38 +0000 [thread overview]
Message-ID: <20170704152438.GA30443@lynnl.yet> (raw)
Fixed a constant-left comparison warning issue check by
scripts/checkpatch.pl:
WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
drivers/video/fbdev/sm712fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 172e94146878..502d0de2feec 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1478,7 +1478,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
}
/* can support 32 bpp */
- if (15 = sfb->fb->var.bits_per_pixel)
+ if (sfb->fb->var.bits_per_pixel = 15)
sfb->fb->var.bits_per_pixel = 16;
sfb->fb->var.xres_virtual = sfb->fb->var.xres;
--
2.13.2
next reply other threads:[~2017-07-04 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170704152446epcas5p1e19c064adddaba7963deea1b91d23fa4@epcas5p1.samsung.com>
2017-07-04 15:24 ` Lynn Lei [this message]
2017-08-01 12:14 ` [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704152438.GA30443@lynnl.yet \
--to=lynnl.yet@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).