* [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning @ 2017-07-04 15:24 ` Lynn Lei 2017-08-01 12:14 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Lynn Lei @ 2017-07-04 15:24 UTC (permalink / raw) To: sudipm.mukherjee; +Cc: teddy.wang, b.zolnierkie, linux-fbdev, linux-kernel Fixed a constant-left comparison warning issue check by scripts/checkpatch.pl: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Lynn Lei <lynnl.wit@gmail.com> --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index 172e94146878..502d0de2feec 100644 --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1478,7 +1478,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, } /* can support 32 bpp */ - if (15 = sfb->fb->var.bits_per_pixel) + if (sfb->fb->var.bits_per_pixel = 15) sfb->fb->var.bits_per_pixel = 16; sfb->fb->var.xres_virtual = sfb->fb->var.xres; -- 2.13.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning 2017-07-04 15:24 ` [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning Lynn Lei @ 2017-08-01 12:14 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-08-01 12:14 UTC (permalink / raw) To: Lynn Lei; +Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-kernel On Tuesday, July 04, 2017 11:24:38 PM Lynn Lei wrote: > Fixed a constant-left comparison warning issue check by > scripts/checkpatch.pl: > WARNING: Comparisons should place the constant on the right side of the test > > Signed-off-by: Lynn Lei <lynnl.wit@gmail.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-01 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170704152446epcas5p1e19c064adddaba7963deea1b91d23fa4@epcas5p1.samsung.com>
2017-07-04 15:24 ` [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning Lynn Lei
2017-08-01 12:14 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).