From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 19 Jul 2017 07:39:10 +0000 Subject: Re: [PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags Message-Id: <20170719073910.kkhcrfmzz7c2jpzo@phenom.ffwll.local> List-Id: References: <20170706125735.28299-1-daniel.vetter@ffwll.ch> <20170706125735.28299-4-daniel.vetter@ffwll.ch> In-Reply-To: <20170706125735.28299-4-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: DRI Development Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Intel Graphics Development , virtualization@lists.linux-foundation.org, Gerd Hoffmann , Daniel Vetter , Dave Airlie On Thu, Jul 06, 2017 at 02:57:34PM +0200, Daniel Vetter wrote: > It's not accelarated, just system memory. Note we don't even need to > set the default flag since that's now always 0. > > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Daniel Vetter Merged with Dave's irc-ack + commit message amended that qxl once had accel, but that was removed in 2015. -Daniel > --- > drivers/gpu/drm/qxl/qxl_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c > index 573e7e9a5f98..69e7359b562a 100644 > --- a/drivers/gpu/drm/qxl/qxl_fb.c > +++ b/drivers/gpu/drm/qxl/qxl_fb.c > @@ -275,7 +275,7 @@ static int qxlfb_create(struct qxl_fbdev *qfbdev, > > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); > > - info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT; > + info->flags = FBINFO_DEFAULT; > info->fbops = &qxlfb_ops; > > /* > -- > 2.13.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch