From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 26 Jul 2017 14:50:52 +0000 Subject: Re: [PATCH RESEND] fbdev: omapfb: remove unused variable Message-Id: <20170726145052.qpuxx37dible2vie@phenom.ffwll.local> List-Id: References: <20170726135816.2216688-1-arnd@arndb.de> <10646277.hB6jvi1uWb@amdc3058> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , dri-devel , Tomi Valkeinen , Laurent Pinchart , linux-omap@vger.kernel.org On Wed, Jul 26, 2017 at 04:31:38PM +0200, Arnd Bergmann wrote: > On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: > >> Removing the default display name left a harmless warning: > >> > >> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': > >> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] > >> > >> This removes the now-unused variable as well. > >> > >> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") > >> Signed-off-by: Arnd Bergmann > >> Reviewed-by: Laurent Pinchart > >> --- > >> Originally submitted on June 9, no reply other than the Reviewed-by tag. > >> The patch is still needed > > > > It is not lost and will be queued for 4.13 fbdev fixes pull request. > > Ok, thanks a lot! > > > [ The guilty commit went through DRM tree and pulling it into fbdev > > tree just to fix the warning was not feasible.. ] > > Yes, I was originally hoping the fix could be merged along with the > patch that introduced the bug. I may have messed up the Cc list for that > though. Should we add dri-devel as an mailing list entry to the fbdev system in MAINTAINERS? Iirc there's almost no traffic for fbdev itself, and this would avoid such a fumble in the future. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch