* [PATCH] video: fbdev: aty: do not leak uninitialized padding in clk to userspace @ 2017-08-29 13:50 ` Vladis Dronov 2017-09-04 13:32 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Vladis Dronov @ 2017-08-29 13:50 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, linux-fbdev, linux-kernel; +Cc: Vladis Dronov 'clk' is copied to a userland with padding byte(s) after 'vclk_post_div' field unitialized, leaking data from the stack. Fix this ensuring all of 'clk' is initialized to zero. References: https://github.com/torvalds/linux/pull/441 Reported-by: sohu0106 <sohu0106@126.com> Signed-off-by: Vladis Dronov <vdronov@redhat.com> --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b55fdac..e4c91d7 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -1855,7 +1855,7 @@ static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg) #if defined(DEBUG) && defined(CONFIG_FB_ATY_CT) case ATYIO_CLKR: if (M64_HAS(INTEGRATED)) { - struct atyclk clk; + struct atyclk clk = { 0 }; union aty_pll *pll = &par->pll; u32 dsp_config = pll->ct.dsp_config; u32 dsp_on_off = pll->ct.dsp_on_off; -- 2.9.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: aty: do not leak uninitialized padding in clk to userspace 2017-08-29 13:50 ` [PATCH] video: fbdev: aty: do not leak uninitialized padding in clk to userspace Vladis Dronov @ 2017-09-04 13:32 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-09-04 13:32 UTC (permalink / raw) To: Vladis Dronov; +Cc: linux-fbdev, linux-kernel On Tuesday, August 29, 2017 03:50:04 PM Vladis Dronov wrote: > 'clk' is copied to a userland with padding byte(s) after 'vclk_post_div' > field unitialized, leaking data from the stack. Fix this ensuring all of > 'clk' is initialized to zero. > > References: https://github.com/torvalds/linux/pull/441 > Reported-by: sohu0106 <sohu0106@126.com> > Signed-off-by: Vladis Dronov <vdronov@redhat.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-04 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170829135015epcas3p2c8daeacf3b6b2960cf13f225231b19c2@epcas3p2.samsung.com>
2017-08-29 13:50 ` [PATCH] video: fbdev: aty: do not leak uninitialized padding in clk to userspace Vladis Dronov
2017-09-04 13:32 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).