From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 13 Sep 2017 16:20:31 +0000 Subject: Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Message-Id: <20170913.092031.2176431746672254970.davem@davemloft.net> List-Id: References: <1505287939-14106-1-git-send-email-allen.lkml@gmail.com> <1505287939-14106-6-git-send-email-allen.lkml@gmail.com> In-Reply-To: <1505287939-14106-6-git-send-email-allen.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: allen.lkml@gmail.com Cc: linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, megaraidlinux.pdl@broadcom.com, target-devel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-btrfs@vger.kernel.org From: Allen Pais Date: Wed, 13 Sep 2017 13:02:15 +0530 > Signed-off-by: Allen Pais This is quite pointless as the caller doesn't do anything with the value, it just tests whether a negative value is returned or not.