From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: b.zolnierkie@samsung.com, tj@kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 6/8] video: fbdev: au1200fb: Remove some dead code
Date: Tue, 17 Oct 2017 11:33:49 +0000 [thread overview]
Message-ID: <20171017113349.mee6ktysujsui7rj@mwanda> (raw)
In-Reply-To: <d4ef5b40a6ba8b468bd22cc8e429260c42b2fb7f.1508179264.git.christophe.jaillet@wanadoo.fr>
On Mon, Oct 16, 2017 at 09:04:52PM +0200, Christophe JAILLET wrote:
> There is no need to shut gcc up. It should not complain.
> Axe 'fbdev', it is never used in this function.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/video/fbdev/au1200fb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c
> index e531543bc707..970ce761ff89 100644
> --- a/drivers/video/fbdev/au1200fb.c
> +++ b/drivers/video/fbdev/au1200fb.c
> @@ -1667,10 +1667,6 @@ static int au1200fb_drv_probe(struct platform_device *dev)
> printk(DRIVER_NAME ": Panel %d %s\n", panel_index, panel->name);
> printk(DRIVER_NAME ": Win %d %s\n", window_index, win->name);
>
> - /* shut gcc up */
> - ret = 0;
Heh... It looks like they were deliberately silencing the warning about
the bug you fixed in patch 2/8. :P
regards,
dan carpenter
next prev parent reply other threads:[~2017-10-17 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171016190602epcas2p1c54546e982659187188f178846c54531@epcas2p1.samsung.com>
2017-10-16 19:04 ` [PATCH 0/8] video: fbdev: au1200fb: Fix error handling path of 'au1200fb_drv_probe()' Christophe JAILLET
2017-10-16 19:04 ` [PATCH 1/8] video: fbdev: au1200fb: Fix a potential double free Christophe JAILLET
2017-10-16 19:04 ` [PATCH 2/8] video: fbdev: au1200fb: Return an error code if a memory allocation fails Christophe JAILLET
2017-10-16 19:04 ` [PATCH 3/8] video: fbdev: au1200fb: Release some resources " Christophe JAILLET
2017-10-16 19:04 ` [PATCH 4/8] video: fbdev: au1200fb: Fix error handling path Christophe JAILLET
2017-10-16 19:04 ` [PATCH 5/8] " Christophe JAILLET
2017-10-17 10:35 ` walter harms
2017-10-16 19:04 ` [PATCH 6/8] video: fbdev: au1200fb: Remove some dead code Christophe JAILLET
2017-10-17 11:33 ` Dan Carpenter [this message]
2017-10-16 19:04 ` [PATCH 7/8] video: fbdev: au1200fb: Propagate an error code Christophe JAILLET
2017-10-16 19:04 ` [PATCH 8/8] video: fbdev: au1200fb: Style clean up Christophe JAILLET
2017-11-09 13:12 ` [PATCH 0/8] video: fbdev: au1200fb: Fix error handling path of 'au1200fb_drv_probe()' Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017113349.mee6ktysujsui7rj@mwanda \
--to=dan.carpenter@oracle.com \
--cc=b.zolnierkie@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox