Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>, Pavel Machek <pavel@ucw.cz>,
	Richard Purdie <rpurdie@rpsys.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching back
Date: Fri, 27 Oct 2017 14:38:11 +0000	[thread overview]
Message-ID: <20171027140307.x7mtgvy5py7l5nqf@rob-hp-laptop> (raw)
In-Reply-To: <1509022186-19636-4-git-send-email-LW@KARO-electronics.de>

On Thu, Oct 26, 2017 at 02:49:46PM +0200, Lothar Waßmann wrote:
> When switching the backlight on, the LCD may need some time to adjust
> to the configured PWM duty cycle. Add a configurable delay between
> configuring the PWM and enabling the backlight regulator to account
> for this.
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>  .../bindings/leds/backlight/pwm-backlight.txt      |  4 ++++
>  drivers/video/backlight/pwm_bl.c                   | 22 +++++++++++++++++++---
>  2 files changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> index 764db86..95594c3 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> @@ -17,6 +17,10 @@ Optional properties:
>                 "pwms" property (see PWM binding[0])
>    - enable-gpios: contains a single GPIO specifier for the GPIO which enables
>                    and disables the backlight (see GPIO binding[1])
> +  - turn-on-delay-ms: delay in milliseconds between configuring the PWM
> +		  and switching PWM on. This may be required to eliminate
> +		  flicker when switching the PWM on after it has been
> +		  disabled.

The subject talks about turning on the backlight regulator, but this 
only talks about the PWM.

>  
>  [0]: Documentation/devicetree/bindings/pwm/pwm.txt
>  [1]: Documentation/devicetree/bindings/gpio/gpio.txt

  reply	other threads:[~2017-10-27 14:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 12:49 [PATCH 0/2] backlight: pwm_bl: prevent backlight flicker when switching PWM on Lothar Waßmann
     [not found] ` <1509022186-19636-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-26 12:49   ` Lothar Waßmann
     [not found]     ` <1509022186-19636-2-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-11-08 10:48       ` Daniel Thompson
2017-11-10 11:22         ` Enric Balletbo i Serra
2017-11-14  7:56           ` Lothar Waßmann
2017-10-26 12:49   ` [PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching backligh Lothar Waßmann
2017-10-27 14:38     ` Rob Herring [this message]
2017-10-30 10:33       ` [PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching back Lee Jones
2017-11-08  0:46         ` Rob Herring
2017-11-08  7:34           ` Lothar Waßmann
2017-11-08  9:12             ` Lee Jones
2017-11-08  9:44               ` Lothar Waßmann
2017-10-26 12:49 ` [PATCH 1/2] backlight: pwm_bl: Enable PWM before switching regulator on Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027140307.x7mtgvy5py7l5nqf@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=LW@KARO-electronics.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox