From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()
Date: Mon, 06 Nov 2017 09:53:45 +0000 [thread overview]
Message-ID: <20171106095345.ds5ftmdmq4xjnadg@mwanda> (raw)
In-Reply-To: <5e11db02-618e-ac60-921f-2971458a4484@users.sourceforge.net>
On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote:
> >> If you want to lower the size of strings in this driver, you can do it,
> >> but not like this.
> >
> > Just so we're clear, GCC already detects and combines it when you use
> > the same string constant twice.
>
> Do you distinguish between merging of constants and the combination
> of statements for such an use case?
I would have rejected the patch even if GCC didn't combine the strings
because the most important thing is that the code is readable.
regards,
dan carpenter
next prev parent reply other threads:[~2017-11-06 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 13:10 [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() SF Markus Elfring
2017-11-06 8:40 ` Nicolas Ferre
2017-11-06 8:53 ` Dan Carpenter
2017-11-06 9:00 ` SF Markus Elfring
2017-11-06 9:53 ` Dan Carpenter [this message]
2017-11-06 9:32 ` SF Markus Elfring
2017-11-06 10:06 ` Nicolas Ferre
2017-11-06 18:14 ` [PATCH v2] video: atmel_lcdfb: Use unique error messages " SF Markus Elfring
2017-11-06 18:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106095345.ds5ftmdmq4xjnadg@mwanda \
--to=dan.carpenter@oracle.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox