From: Ladislav Michl <ladis@linux-mips.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "Andrew F. Davis" <afd@ti.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Mon, 27 Nov 2017 17:44:54 +0000 [thread overview]
Message-ID: <20171127174454.GA18851@lenoch> (raw)
In-Reply-To: <502de06b-ca86-d0ff-bd50-d260fbe46fe5@users.sourceforge.net>
On Mon, Nov 27, 2017 at 06:27:08PM +0100, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in these functions.
> …
> > nak, unlike many others, these message give extra info on which
> > allocation failed, that can be useful.
>
> Can a default allocation failure report provide the information
> which you might expect so far?
You should be able to answer that question yourself. And if you are
unable to do so, just do not sent changes pointed by any code analysis
tools.
As a side note, if you look at whole call chain, you'll find quite some
room for optimizations - look how dev and pdev are used. That also applies
to other patches.
Best regards,
ladis
next prev parent reply other threads:[~2017-11-27 17:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 18:55 [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 17:27 ` SF Markus Elfring
2017-11-27 17:44 ` Ladislav Michl [this message]
2017-11-27 18:12 ` SF Markus Elfring
2017-11-27 18:56 ` Geert Uytterhoeven
2017-11-27 19:22 ` Ladislav Michl
2017-11-27 22:20 ` Ladislav Michl
2017-11-27 19:07 ` [PATCH] " Joe Perches
2017-11-27 21:33 ` Andrew F. Davis
2017-11-27 21:45 ` Ladislav Michl
2017-11-27 21:48 ` SF Markus Elfring
2017-11-28 1:45 ` Joe Perches
2017-11-28 7:41 ` SF Markus Elfring
2017-11-28 7:49 ` Julia Lawall
2017-11-28 8:49 ` SF Markus Elfring
2017-11-28 9:26 ` Julia Lawall
2017-11-28 9:56 ` SF Markus Elfring
2017-11-28 8:04 ` Joe Perches
2017-11-28 8:49 ` Ladislav Michl
2017-11-28 9:11 ` SF Markus Elfring
2017-11-28 9:28 ` Julia Lawall
2017-11-28 10:15 ` SF Markus Elfring
2017-11-28 10:23 ` Ladislav Michl
2017-11-28 10:50 ` SF Markus Elfring
2017-11-28 11:41 ` Ladislav Michl
2017-11-28 12:13 ` SF Markus Elfring
2017-11-28 17:50 ` Ladislav Michl
2017-11-28 18:09 ` SF Markus Elfring
2017-11-28 14:36 ` Joe Perches
2017-12-03 18:20 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127174454.GA18851@lenoch \
--to=ladis@linux-mips.org \
--cc=afd@ti.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).