linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Cc: "Thierry Reding"
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	"Tomi Valkeinen" <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
	"Bartlomiej Zolnierkiewicz"
	<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Laurent Pinchart"
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	"Julia Lawall" <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>,
	"Sean Paul" <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org,
	kernel-Jl6IXVxNIMRxAtABVqVhTwC/G2K4zDHf@public.gmane.org
Subject: Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string
Date: Tue, 28 Nov 2017 16:00:57 +0000	[thread overview]
Message-ID: <20171128160057.GB28152@atomide.com> (raw)
In-Reply-To: <F14B3797-8154-4958-82AB-8E39C75BB97B-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>

* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:51]:
> > Am 28.11.2017 um 16:10 schrieb Tony Lindgren <tony@atomide.com>:
> > OK fine dropping both. Please update the description in both dts
> > patches to make it clear they are needed as a fix. Preferrably
> > with a proper fixes tag.
> 
> Well, it is not "needed" in a strong sense since current mainline&stable
> works. It is more a style and consistency fix to use "tpo," everywhere.
> 
> > 
> > Having "We can remove the "omapdss," prefix" in the description sure
> > does not sounds like it's needed as a fix :)
> 
> The description has been improved on -v3.

Thanks.

> > Sounds like maybe these two should be just a single patch for
> > a proper fix?
> 
> Hm. I usually get the feedback to separate DT and driver fixes into
> separate commits... Therefore I submit patch sets in the hope they
> are not picked apart :)

See "both dts patches" part above. Yes the dts patches can and should
be sent separately. In almost every case if the dts patches cannot be
applied separately it means your driver changes are breaking things.

Regards,

Tony

  parent reply	other threads:[~2017-11-28 16:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  8:50 [PATCH v2 0/4] Fixes for omapdrm on OpenPandora and GTA04 H. Nikolaus Schaller
     [not found] ` <cover.1510822218.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-16  8:50   ` [PATCH v2 1/4] omapdrm: fix compatible string for td028ttec1 H. Nikolaus Schaller
2017-11-16 12:32     ` Tomi Valkeinen
     [not found]       ` <4753a425-d050-7f2d-35ae-b387accfd99e-l0cyMroinI0@public.gmane.org>
2017-11-16 13:43         ` H. Nikolaus Schaller
2017-11-16 15:53           ` Andrew F. Davis
2017-11-16 16:10             ` H. Nikolaus Schaller
2017-11-16 17:08               ` Andrew F. Davis
2017-11-16 18:18                 ` H. Nikolaus Schaller
2017-11-16 18:32                   ` Andrew F. Davis
2017-11-16 18:56                     ` H. Nikolaus Schaller
2017-11-20  5:36                       ` H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string H. Nikolaus Schaller
     [not found]     ` <09d975dd62afa1dfa43d94079cc9a44731af4b3b.1510822218.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-28 14:57       ` Tony Lindgren
2017-11-28 15:01         ` H. Nikolaus Schaller
2017-11-28 15:10           ` Tony Lindgren
2017-11-28 15:48             ` H. Nikolaus Schaller
     [not found]               ` <F14B3797-8154-4958-82AB-8E39C75BB97B-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-28 16:00                 ` Tony Lindgren [this message]
2017-11-28 16:04                   ` H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 3/4] DTS: Pandora: " H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 4/4] drm: omapdrm: Fix DPI on platforms using the DSI VDDS H. Nikolaus Schaller
2017-11-21 10:25     ` Tomi Valkeinen
2017-11-21 10:38       ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128160057.GB28152@atomide.com \
    --to=tony@atomide.com \
    --cc=Julia.Lawall-L2FTfq7BK8M@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org \
    --cc=kernel-Jl6IXVxNIMRxAtABVqVhTwC/G2K4zDHf@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).