linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/6] video: udlfb: Remove unnecessary local variable
@ 2017-12-11 21:41 Ladislav Michl
  0 siblings, 0 replies; only message in thread
From: Ladislav Michl @ 2017-12-11 21:41 UTC (permalink / raw)
  To: linux-fbdev

'urb' is not needed and can be removed.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 drivers/video/fbdev/udlfb.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 4abf538c9b72..f74facaed8cc 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1919,7 +1918,6 @@ static struct urb *dlfb_get_urb(struct dlfb_data *dlfb)
 	int ret;
 	struct list_head *entry;
 	struct urb_node *unode;
-	struct urb *urb = NULL;
 	unsigned long flags;
 
 	/* Wait for an in-flight buffer to complete and get re-queued */
@@ -1928,7 +1926,7 @@ static struct urb *dlfb_get_urb(struct dlfb_data *dlfb)
 		atomic_set(&dlfb->lost_pixels, 1);
 		pr_warn("wait for urb interrupted: %x available: %d\n",
 		       ret, dlfb->urbs.available);
-		goto error;
+		return NULL;
 	}
 
 	spin_lock_irqsave(&dlfb->urbs.lock, flags);
@@ -1941,10 +1939,7 @@ static struct urb *dlfb_get_urb(struct dlfb_data *dlfb)
 	spin_unlock_irqrestore(&dlfb->urbs.lock, flags);
 
 	unode = list_entry(entry, struct urb_node, entry);
-	urb = unode->urb;
-
-error:
-	return urb;
+	return unode->urb;
 }
 
 static int dlfb_submit_urb(struct dlfb_data *dlfb, struct urb *urb, size_t len)
-- 
2.15.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-12-11 21:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 21:41 [PATCH 3/6] video: udlfb: Remove unnecessary local variable Ladislav Michl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).