From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Wed, 03 Jan 2018 09:49:53 +0000 Subject: Re: [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio Message-Id: <20180103094953.dhlzmyz6c2mymv7v@oak.lan> List-Id: References: <20171013194250.9001-1-robert.jarzmik@free.fr> <20171013194250.9001-2-robert.jarzmik@free.fr> <20171215115309.ez7odo7sh5zz7vge@oak.lan> <87shcaewah.fsf@belgarion.home> <874logbar8.fsf@belgarion.home> In-Reply-To: <874logbar8.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Jarzmik Cc: Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Dec 24, 2017 at 12:55:55PM +0100, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Daniel Thompson writes: > > > >> On Fri, Oct 13, 2017 at 09:42:48PM +0200, Robert Jarzmik wrote: > >> Also, this adds a new optional property, doesn't the devicetree binding > >> docs need to be update to match this? > > Ah yes, that too. I'll add it for v3. > Actually I won't ... because there is no description for tdo24m I could find. > > If that's a problem for you, I'll drop that patch as well. I think I'm ok to drop this, if only because based on current upstream state I think this code will never be given a reset line anyway (or is there a partner patch for mach-pxa that hasn't been posted yet). Daniel.