From: Ladislav Michl <ladis@linux-mips.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 0/5] video: udlfb: (not only) Logging cleanup
Date: Mon, 15 Jan 2018 15:30:19 +0000 [thread overview]
Message-ID: <20180115153019.GA2232@lenoch> (raw)
In-Reply-To: <20180104193623.GA22612@lenoch>
Bartlomiej,
On Mon, Jan 15, 2018 at 03:28:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
> I queued patches #1-4 for v4.16, thanks.
>
> > > video: udlfb: Switch from the pr_*() to the dev_*() logging functions
>
> This one introduces new compile time warning:
>
> drivers/video/fbdev/udlfb.c: In function ‘dlfb_init_framebuffer_work’:
> drivers/video/fbdev/udlfb.c:1694:24: warning: ignoring return value of ‘device_create_bin_file’, declared with attribute warn_unused_result [-Wunused-result]
> device_create_bin_file(info->dev, &edid_attr);
> ^
>
> Checking of device_create_bin_file()'s return value should not be removed,
>
> [ ditto for device_create_file() ]
>
> Also please fix the new comment introduced by the patch:
>
> + /* parent device is used otherwise*/
>
> [ ...e*/ -> ...e */ ]
Fixed those and few more checkpatch warnings and will send v3 of just this
patch. However I'd like to know what toolchain are you using as I didn't
see above warning.
Thank you,
ladis
next prev parent reply other threads:[~2018-01-15 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 19:36 [PATCH v2 0/5] video: udlfb: (not only) Logging cleanup Ladislav Michl
2018-01-08 16:55 ` Ladislav Michl
2018-01-15 14:28 ` Bartlomiej Zolnierkiewicz
2018-01-15 15:30 ` Ladislav Michl [this message]
2018-01-15 15:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115153019.GA2232@lenoch \
--to=ladis@linux-mips.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).