Re: [PATCH 2/5] backlight: lp855x: document sysfs attributes

Aishwarya Pant
2018-02-01T15:58:56Z

On Thu, Feb 01, 2018 at 11:06:42AM +0000, Daniel Thompson wrote:
> On Fri, Jan 26, 2018 at 08:23:00PM +0530, Aishwarya Pant wrote:
> > Add documentation for sysfs interface of Texas Instruments lp855x
> > backlight driver by reading code and looking through git commit logs.
> >
> > Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> > ---
> > .../ABI/testing/sysfs-class-backlight-lp855x | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp855x
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-backlight-lp855x b/Documentation/ABI/testing/sysfs-class-backlight-lp855x
> > new file mode 100644
> > index 000000000000..5b9d38958875
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-class-backlight-lp855x
> > @@ -0,0 +1,19 @@
> > +sysfs interface for Texas Instruments lp855x backlight driver
> > +------------------------------------------------------------
> > +
> > +What: /sys/class/backlight/<backlight>/chip_id
> > +Date: Mar, 2012
> > +KernelVersion: v3.10
> > +Contact: Milo Kim <milo.kim@ti.com>
> > +Description:
> > + (RO) Displays the lp8755x chip id. Possible values are:
> > + lp8550, lp8551, lp8552, lp8553, lp8555, lp8556 or lp8557.
> > +
> > +
> > +What: /sys/class/backlight/<backlight>/bl_ctl_mode
> > +Date: Mar, 2012
> > +KernelVersion: v3.10
> > +Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>
> > +Description:
> > + (RO) Displays whether the brightness is controlled by the pwm
> > + input("pwm based) or the i2c register("register based").
>
> Since like the first patch in the series, these look like they are for
> debugging. That thread is still active but whatever the outcome of that
> thread please assume it also applies to this patch.

All right, I'll wait for conclusion on that thread before I re-send the patchset
with the updates.

Aishwarya

>
>
> Daniel.