From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 19 Feb 2018 09:22:47 +0000 Subject: Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties. Message-Id: <20180219092247.estv4d2v6cbopx6z@dell> List-Id: References: <20180216174034.15936-1-enric.balletbo@collabora.com> <20180216174034.15936-2-enric.balletbo@collabora.com> In-Reply-To: <20180216174034.15936-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Enric Balletbo i Serra Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Thompson , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Thierry Reding , Jacek Anaszewski , Pavel Machek , groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Richard Purdie , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote: > Hardware needs a delay between setting an initial (non-zero) PWM and > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > this delay in milli seconds. Hardware also needs a delay between disabing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. >=20 > Signed-off-by: Enric Balletbo i Serra > Acked-by: Pavel Machek > --- > Based on the original Huang Lin work. >=20 > Changes since v4: > - Rebase on top of mainline. > Changes since v3: > - Replace us for ms. > - Add Acked-by: Pavel Machek > Changes since v2: > - Use separate properties (Rob Herring) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same >=20 > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 += +++++ > 1 file changed, 6 insertions(+) Looks like this still needs an Ack. Also, you didn't supply a 0th (cover-letter) patch, so I have no idea of patch history or your future intentions. Are there build-time dependencies between them or can each patch be merged via their respective trees without the fear of merge/build failure? --=20 Lee Jones Linaro Services Technical Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog