From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 12 Mar 2018 09:10:41 +0000 Subject: Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties. Message-Id: <20180312091041.5sk3t27n5tryikie@dell> List-Id: References: <20180216174034.15936-1-enric.balletbo@collabora.com> <20180216174034.15936-2-enric.balletbo@collabora.com> <20180219111136.jpv4wtcm6h2hfwac@oak.lan> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Enric Balletbo Serra Cc: Daniel Thompson , Enric Balletbo i Serra , Jingoo Han , Rob Herring , Pavel Machek , Heiko Stuebner , Thierry Reding , Bartlomiej Zolnierkiewicz , Richard Purdie , Jacek Anaszewski , Linux PWM List , linux-fbdev@vger.kernel.org, linux-kernel , Guenter Roeck , "open list:ARM/Rockchip SoC..." , kernel@collabora.com, "devicetree@vger.kernel.org" , Mark Rutland FAO Thierry, > oh, devicetree mailing list is not added, sorry, so cc'ing ... > > 2018-02-19 12:11 GMT+01:00 Daniel Thompson : > > On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote: > >> Hardware needs a delay between setting an initial (non-zero) PWM and > >> enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > >> this delay in milli seconds. Hardware also needs a delay between disabing > >> the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > >> is this delay in milli seconds. > >> > >> Signed-off-by: Enric Balletbo i Serra > >> Acked-by: Pavel Machek > > > > Acked-by: Daniel Thompson > > > > Lee, I guess that after Daniel ack the only ack missing here is one > from Rob Herring? I'd also like an ACK from the PWM Maintainer if possible. > Rob, if you have a chance to look at this I'd appreciate. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog