public inbox for linux-fbdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Felix Brack <fb@ltec.ch>
Cc: linux-fbdev@vger.kernel.org, daniel.thompson@linaro.org,
	jingoohan1@gmail.com, b.zolnierkie@samsung.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] backlight: otm3225a: add support for ORISE OTM3225A LCD SoC
Date: Thu, 15 Mar 2018 08:18:54 +0000	[thread overview]
Message-ID: <20180315081854.lsp5gmvqkgrgniln@dell> (raw)
In-Reply-To: <caedb4f3-c508-5ebf-8873-af095fecf03e@ltec.ch>

On Wed, 14 Mar 2018, Felix Brack wrote:
> On 27.12.2017 16:20, Felix Brack wrote:
> > This patch adds a LCD driver supporting the OTM3225A LCD SoC
> > from ORISE Technology. This device can drive TFT LC panels having a
> > resolution of 240x320 pixels. After initializing the OTM3225A using
> > it's SPI interface it switches to use 16-bib RGB as external
> > display interface.
> > 
> > Signed-off-by: Felix Brack <fb@ltec.ch>
> > 
> > Changes in v2:
> > - use descriptive names for registers instead of hard coding them
> > - remove unnecessary registers in initialization sequence
> > - make use of resource-managed functions like devm_kzalloc()
> >   instead of kzalloc() which simplifies and shortens the code
> > - replace mdelay() by msleep()
> > - use module_spi_init() since we do not do anything special
> >   in init/exit
> > - use dev_name() instead of hard coding driver name multiple times
> > - use static storage class for structure otm3225a_ops
> > - sort include files alphabetically
> > - use standardized licensing header
> > - modify Makefile respecting alphabetical sort order
> > ---
> >  drivers/video/backlight/Kconfig    |   7 ++
> >  drivers/video/backlight/Makefile   |   1 +
> >  drivers/video/backlight/otm3225a.c | 251 +++++++++++++++++++++++++++++++++++++
> >  3 files changed, 259 insertions(+)
> >  create mode 100644 drivers/video/backlight/otm3225a.c

[...]

> Just a gentle echo request: This patch was sent and Acked more then two
> months ago. Is there anything preventing it from being queued for a
> future kernel release?

Please take care to snip unnecessarily long quotes when replying to
patches.

This patch still needs Daniel Thompson's Acked-by/Reviewed-by. 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-03-15  8:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-27 15:20 [PATCH v2] backlight: otm3225a: add support for ORISE OTM3225A LCD SoC Felix Brack
2017-12-27 15:28 ` Jingoo Han
2018-03-14 14:09 ` Felix Brack
2018-03-15  8:18   ` Lee Jones [this message]
2018-04-05 16:04 ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315081854.lsp5gmvqkgrgniln@dell \
    --to=lee.jones@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.thompson@linaro.org \
    --cc=fb@ltec.ch \
    --cc=jingoohan1@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox