linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Heiko Stuebner <heiko@sntech.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, groeck@chromium.org,
	linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [RESEND PATCH v5 3/5] pwm-backlight: add support for PWM delays proprieties.
Date: Mon, 19 Mar 2018 16:59:22 +0000	[thread overview]
Message-ID: <20180319165922.GD22770@ulmo> (raw)
In-Reply-To: <20180216174034.15936-3-enric.balletbo@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

On Fri, Feb 16, 2018 at 06:40:32PM +0100, Enric Balletbo i Serra wrote:
> Some panels (i.e. N116BGE-L41), in their power sequence specifications,
> request a delay between set the PWM signal and enable the backlight and
> between clear the PWM signal and disable the backlight. Add support for
> the new post-pwm-on-delay-ms and pwm-off-delay-ms proprieties to meet
> the timings.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
> ---
> Changes since v4:
>  - Rebased on top of mainline.
>  - Added the acks from Pavel Machek, Daniel thompson and Jingoo Han
> Changes since v3:
>  - Use two named members instead of pwm_delay[] (Daniel and Pavel)
>  - Use msleep instead of usleep_range. (Pavel)
> Changes since v2:
>  - Move the pwm/enable sequence to another patch (Thierry Reding)
> Changes since v1:
>  - As suggested by Daniel Thompson
>    - Do not assume power-on delay and power-off delay will be the same
>  - Move the check of dt property to the parse dt function.
> 
>  drivers/video/backlight/pwm_bl.c | 19 +++++++++++++++++++
>  include/linux/pwm_backlight.h    |  2 ++
>  2 files changed, 21 insertions(+)

Acked-by: Thierry Reding <thierry.reding@gmail.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-03-19 16:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 17:40 [RESEND PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Enric Balletbo i Serra
2018-02-16 17:40 ` [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties Enric Balletbo i Serra
     [not found]   ` <20180216174034.15936-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-19  9:22     ` Lee Jones
2018-02-19  9:56       ` Heiko Stuebner
2018-02-19 10:39         ` Lee Jones
2018-02-19 11:11     ` Daniel Thompson
2018-03-09 10:14       ` Enric Balletbo Serra
2018-03-12  9:10         ` Lee Jones
2018-03-19 16:58   ` Thierry Reding
2018-02-16 17:40 ` [RESEND PATCH v5 3/5] pwm-backlight: add support for PWM delays proprieties Enric Balletbo i Serra
2018-03-19 16:59   ` Thierry Reding [this message]
2018-02-16 17:40 ` [RESEND PATCH v5 4/5] ARM: dts: rockchip: set PWM delay backlight settings for Veyron Enric Balletbo i Serra
2018-02-16 17:40 ` [RESEND PATCH v5 5/5] ARM: dts: rockchip: set PWM delay backlight settings for Minnie Enric Balletbo i Serra
     [not found] ` <20180216174034.15936-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-03-19 16:58   ` [RESEND PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Thierry Reding
2018-03-19 18:28     ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319165922.GD22770@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.thompson@linaro.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=heiko@sntech.de \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=kernel@collabora.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).