From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Tue, 27 Mar 2018 15:08:27 +0000 Subject: Re: [PATCH v6 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties. Message-Id: <20180327150827.i7b4urmjrf2mqj3t@rob-hp-laptop> List-Id: References: <20180326095213.18362-1-enric.balletbo@collabora.com> <20180326095213.18362-2-enric.balletbo@collabora.com> In-Reply-To: <20180326095213.18362-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Enric Balletbo i Serra Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Heiko Stuebner , Thierry Reding , Bartlomiej Zolnierkiewicz , Richard Purdie , Jacek Anaszewski , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, groeck@chromium.org, linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com On Mon, Mar 26, 2018 at 11:52:10AM +0200, Enric Balletbo i Serra wrote: > Hardware needs a delay between setting an initial (non-zero) PWM and > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > this delay in milli seconds. Hardware also needs a delay between disabing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Pavel Machek > Acked-by: Thierry Reding > --- > Based on the original Huang Lin work. > Changes since v5: > - Add Acked-by: Thierry Reding > - CC DT mainling list (for some reason dropped at some point, my > fault) > Changes since v4: > - Rebase on top of mainline. > Changes since v3: > - Replace us for ms. > - Add Acked-by: Pavel Machek > Changes since v2: > - Use separate properties (Rob Herring) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same > --- > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Rob Herring