From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 03 Apr 2018 09:19:07 +0000 Subject: Re: [RESEND PATCH v6 3/5] pwm-backlight: add support for PWM delays proprieties. Message-Id: <20180403091907.rfupwgx4ryy66ebu@dell> List-Id: References: <20180328170327.5395-1-enric.balletbo@collabora.com> <20180328170327.5395-3-enric.balletbo@collabora.com> In-Reply-To: <20180328170327.5395-3-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Enric Balletbo i Serra Cc: Daniel Thompson , Jingoo Han , Rob Herring , Pavel Machek , Heiko Stuebner , Thierry Reding , Bartlomiej Zolnierkiewicz , Richard Purdie , Jacek Anaszewski , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, groeck@chromium.org, linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com On Wed, 28 Mar 2018, Enric Balletbo i Serra wrote: > Some panels (i.e. N116BGE-L41), in their power sequence specifications, > request a delay between set the PWM signal and enable the backlight and > between clear the PWM signal and disable the backlight. Add support for > the new post-pwm-on-delay-ms and pwm-off-delay-ms proprieties to meet > the timings. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Pavel Machek > Acked-by: Daniel Thompson > Acked-by: Jingoo Han > Acked-by: Thierry Reding > --- > Changes since v5: > - Add Acked-by: Thierry Reding > Changes since v4: > - Rebased on top of mainline. > - Added the acks from Pavel Machek, Daniel thompson and Jingoo Han > Changes since v3: > - Use two named members instead of pwm_delay[] (Daniel and Pavel) > - Use msleep instead of usleep_range. (Pavel) > Changes since v2: > - Move the pwm/enable sequence to another patch (Thierry Reding) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same > - Move the check of dt property to the parse dt function. > --- > drivers/video/backlight/pwm_bl.c | 19 +++++++++++++++++++ > include/linux/pwm_backlight.h | 2 ++ > 2 files changed, 21 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog