* [PATCH] video: fbdev: pxafb: zero allocated memory for video modes
@ 2018-06-19 9:56 Daniel Mack
2018-06-19 13:10 ` Daniel Mack
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Mack @ 2018-06-19 9:56 UTC (permalink / raw)
To: linux-fbdev
When parsing the video modes from DT properties, make sure to zero out
memory befor using it. This is important because not all fields in the mode
struct are explicitly initialized, even though they are used later on.
Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion)
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/video/fbdev/pxafb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index c2c2e2790079..64926c95d06c 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2131,7 +2131,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
ret = -ENOMEM;
info->modes = kmalloc_array(timings->num_timings,
- sizeof(info->modes[0]), GFP_KERNEL);
+ sizeof(info->modes[0]),
+ GFP_KERNEL | __GFP_ZERO);
if (!info->modes)
goto out;
info->num_modes = timings->num_timings;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: pxafb: zero allocated memory for video modes
2018-06-19 9:56 [PATCH] video: fbdev: pxafb: zero allocated memory for video modes Daniel Mack
@ 2018-06-19 13:10 ` Daniel Mack
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Mack @ 2018-06-19 13:10 UTC (permalink / raw)
To: linux-fbdev
On Tuesday, June 19, 2018 11:56 AM, Daniel Mack wrote:
> When parsing the video modes from DT properties, make sure to zero out
> memory befor using it. This is important because not all fields in the mode
> struct are explicitly initialized, even though they are used later on.
>
> Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion)
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
> drivers/video/fbdev/pxafb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index c2c2e2790079..64926c95d06c 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2131,7 +2131,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
>
> ret = -ENOMEM;
> info->modes = kmalloc_array(timings->num_timings,
> - sizeof(info->modes[0]), GFP_KERNEL);
> + sizeof(info->modes[0]),
> + GFP_KERNEL | __GFP_ZERO);
Ah, kcalloc() is actually nicer. I'll send a v2.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-19 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 9:56 [PATCH] video: fbdev: pxafb: zero allocated memory for video modes Daniel Mack
2018-06-19 13:10 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).