* Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
2018-07-09 21:51 [PATCH] backlight: adp8860: Mark expected switch fall-through Gustavo A. R. Silva
@ 2018-07-10 5:24 ` Lee Jones
2018-07-10 6:46 ` Michael Hennerich
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2018-07-10 5:24 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Daniel Thompson, Michael Hennerich, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-fbdev, dri-devel, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 805 bytes --]
On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Looks good to me, but Dan should still review.
https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc.pdf#page†
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [æŽç¼æ–¯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
2018-07-09 21:51 [PATCH] backlight: adp8860: Mark expected switch fall-through Gustavo A. R. Silva
2018-07-10 5:24 ` Lee Jones
@ 2018-07-10 6:46 ` Michael Hennerich
2018-07-10 9:00 ` Daniel Thompson
2018-07-13 7:35 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Michael Hennerich @ 2018-07-10 6:46 UTC (permalink / raw)
To: Gustavo A. R. Silva, Lee Jones, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel
On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
> switch (ADP8860_MANID(reg_val)) {
> case ADP8863_MANUFID:
> data->gdwn_dis = !!pdata->gdwn_dis;
> + /* fall through */
> case ADP8860_MANUFID:
> data->en_ambl_sens = !!pdata->en_ambl_sens;
> break;
>
--
Greetings,
Michael
--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
2018-07-09 21:51 [PATCH] backlight: adp8860: Mark expected switch fall-through Gustavo A. R. Silva
2018-07-10 5:24 ` Lee Jones
2018-07-10 6:46 ` Michael Hennerich
@ 2018-07-10 9:00 ` Daniel Thompson
2018-07-13 7:35 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Thompson @ 2018-07-10 9:00 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Hennerich, Lee Jones, Jingoo Han,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel
On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Having checked the datasheets...
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
> switch (ADP8860_MANID(reg_val)) {
> case ADP8863_MANUFID:
> data->gdwn_dis = !!pdata->gdwn_dis;
> + /* fall through */
> case ADP8860_MANUFID:
> data->en_ambl_sens = !!pdata->en_ambl_sens;
> break;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
2018-07-09 21:51 [PATCH] backlight: adp8860: Mark expected switch fall-through Gustavo A. R. Silva
` (2 preceding siblings ...)
2018-07-10 9:00 ` Daniel Thompson
@ 2018-07-13 7:35 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2018-07-13 7:35 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Hennerich, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel
On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread