* [PATCH] video: fbdev: tridentfb: Remove unused function
@ 2015-01-13 18:19 Rickard Strandqvist
2018-07-16 13:44 ` [PATCH] video: fbdev: tridentfb: remove deadcode on unreachable case statement Colin King
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-13 18:19 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
Remove the function shadowmode_off() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/tridentfb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
index 7ed9a22..b5cbd2c 100644
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@ -999,11 +999,6 @@ static inline void shadowmode_on(struct tridentfb_par *par)
write3CE(par, CyberControl, read3CE(par, CyberControl) | 0x81);
}
-static inline void shadowmode_off(struct tridentfb_par *par)
-{
- write3CE(par, CyberControl, read3CE(par, CyberControl) & 0x7E);
-}
-
/* Set the hardware to the requested video mode */
static int tridentfb_set_par(struct fb_info *info)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] video: fbdev: tridentfb: remove deadcode on unreachable case statement
2015-01-13 18:19 [PATCH] video: fbdev: tridentfb: Remove unused function Rickard Strandqvist
@ 2018-07-16 13:44 ` Colin King
2018-07-24 16:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-07-16 13:44 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The value of tmp being used in the switch statement has the range of
just 0..3 hence the case 4 statement can never be reached and is
deadcode and can be removed.
Detected by CoverityScan, CID#744384 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/tridentfb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
index 284706184b1b..f4b745590600 100644
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@ -777,9 +777,6 @@ static int get_nativex(struct tridentfb_par *par)
case 3:
x = 800; y = 600;
break;
- case 4:
- x = 1400; y = 1050;
- break;
case 1:
default:
x = 640; y = 480;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: tridentfb: remove deadcode on unreachable case statement
2018-07-16 13:44 ` [PATCH] video: fbdev: tridentfb: remove deadcode on unreachable case statement Colin King
@ 2018-07-24 16:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-07-24 16:50 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
On Monday, July 16, 2018 02:44:58 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The value of tmp being used in the switch statement has the range of
> just 0..3 hence the case 4 statement can never be reached and is
> deadcode and can be removed.
>
> Detected by CoverityScan, CID#744384 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-24 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 18:19 [PATCH] video: fbdev: tridentfb: Remove unused function Rickard Strandqvist
2018-07-16 13:44 ` [PATCH] video: fbdev: tridentfb: remove deadcode on unreachable case statement Colin King
2018-07-24 16:50 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).