From: Thomas Zimmermann <tzimmermann@suse.de>
To: rostedt@goodmis.org, pmladek@suse.com,
linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
hdegoede@redhat.com, akpm@linux-foundation.org,
sergey.senozhatsky.work@gmail.com
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set
Date: Wed, 18 Jul 2018 09:30:02 +0000 [thread overview]
Message-ID: <20180718093002.4596-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20180718093002.4596-1-tzimmermann@suse.de>
If the console is unlocked during registration, the console subsystem
generates significant amounts of warnings, which obfuscate actual
debugging messages. Setting ignore_console_lock_warning while debugging
console registration avoid the noise.
v2:
- restore ignore_console_lock_warning if lock_fb_info() fails
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/core/fbmem.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 9e2f9d3c760e..432c26eeabfb 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1627,6 +1627,7 @@ static int do_register_framebuffer(struct fb_info *fb_info)
int i, ret;
struct fb_event event;
struct fb_videomode mode;
+ bool saved_ignore_console_lock_warning = ignore_console_lock_warning;
if (fb_check_foreignness(fb_info))
return -ENOSYS;
@@ -1691,17 +1692,23 @@ static int do_register_framebuffer(struct fb_info *fb_info)
event.info = fb_info;
if (!lockless_register_fb)
console_lock();
+ else
+ ignore_console_lock_warning = true;
if (!lock_fb_info(fb_info)) {
- if (!lockless_register_fb)
- console_unlock();
- return -ENODEV;
+ ret = -ENODEV;
+ goto unlock_console;
}
+ ret = 0;
fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event);
unlock_fb_info(fb_info);
+unlock_console:
if (!lockless_register_fb)
console_unlock();
- return 0;
+ else
+ ignore_console_lock_warning + saved_ignore_console_lock_warning;
+ return ret;
}
static int do_unregister_framebuffer(struct fb_info *fb_info)
--
2.18.0
next prev parent reply other threads:[~2018-07-18 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 9:30 [PATCH v2 0/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-18 9:30 ` Thomas Zimmermann [this message]
2018-07-18 9:34 ` [PATCH v2 1/1] " Hans de Goede
2018-07-18 19:53 ` kbuild test robot
2018-07-19 8:53 ` Petr Mladek
2018-07-19 10:05 ` Sergey Senozhatsky
2018-07-19 10:20 ` Thomas Zimmermann
2018-07-19 10:33 ` Sergey Senozhatsky
2018-07-19 11:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718093002.4596-2-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).