From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Thu, 19 Jul 2018 10:05:26 +0000 Subject: Re: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Message-Id: <20180719100526.GB424@jagdpanzerIV> List-Id: References: <20180718093002.4596-1-tzimmermann@suse.de> <20180718093002.4596-2-tzimmermann@suse.de> <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz> In-Reply-To: <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Petr Mladek Cc: linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com, hdegoede@redhat.com, rostedt@goodmis.org, Thomas Zimmermann , akpm@linux-foundation.org On (07/19/18 10:53), Petr Mladek wrote: > Hmm, this approach is racy if there are other users > saving/setting/restoring ignore_console_lock_warning in parallel. > I mean that this works only when the entire safe/set/restore > operation is nested or sequential. Good point! However, I tend to think that we don't need to care about it that much. Having a counter to permit nesting would probably be better, but, like you said, it's unlikely that we will see any problems with ignore_console_lock_warning anyway. So we can keep it simple [IOW - the way it is]. -ss