From: Daniel Vetter <daniel@ffwll.ch>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2] fbdev: fix kerneldoc
Date: Fri, 07 Sep 2018 20:07:31 +0000 [thread overview]
Message-ID: <20180907200731.GE7176@phenom.ffwll.local> (raw)
In-Reply-To: <38ca9044455a33e398b45e0281643cc24da3c2fc.1536342224.git.mirq-linux@rere.qmqm.pl>
On Fri, Sep 07, 2018 at 07:47:08PM +0200, Michał Mirosław wrote:
> As noticed by kbuild test robot <lkp@intel.com>,
> remove_conflicting_pci_framebuffers()'s second argument
> is called res_id not resource_id. Fix this.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> * Against drm-misc-next, as that's where original patchset went to.
>
> v2: include second occurrence of @resource_id
Applied, thanks.
-Daniel
>
> ---
> drivers/video/fbdev/core/fbmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
> index 5ffadc8e681d..0da75c55660d 100644
> --- a/drivers/video/fbdev/core/fbmem.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -1834,11 +1834,11 @@ EXPORT_SYMBOL(remove_conflicting_framebuffers);
> /**
> * remove_conflicting_pci_framebuffers - remove firmware-configured framebuffers for PCI devices
> * @pdev: PCI device
> - * @resource_id: index of PCI BAR configuring framebuffer memory
> + * @res_id: index of PCI BAR configuring framebuffer memory
> * @name: requesting driver name
> *
> * This function removes framebuffer devices (eg. initialized by firmware)
> - * using memory range configured for @pdev's BAR @resource_id.
> + * using memory range configured for @pdev's BAR @res_id.
> *
> * The function assumes that PCI device with shadowed ROM drives a primary
> * display and so kicks out vga16fb.
> --
> 2.18.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2018-09-07 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 17:35 [PATCH] fbdev: fix kerneldoc Michał Mirosław
2018-09-07 17:47 ` [PATCH v2] " Michał Mirosław
2018-09-07 20:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907200731.GE7176@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox