* [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code
@ 2018-09-20 20:22 ` Nathan Chancellor
2018-10-08 10:51 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2018-09-20 20:22 UTC (permalink / raw)
To: Thomas Winischhofer, Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison
with extraneous parentheses [-Wparentheses-equality]
} else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous
parentheses around the comparison to silence this warning
} else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
~ ^ ~
drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this
equality comparison into an assignment
} else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
^~
1 warning generated.
Remove the parentheses and while we're at it, clean up the commented
code, which has been here since the beginning of git history.
Link: https://github.com/ClangBuiltLinux/linux/issues/118
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/video/fbdev/sis/init301.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c
index 27a2b72e50e8..a8fb41f1a258 100644
--- a/drivers/video/fbdev/sis/init301.c
+++ b/drivers/video/fbdev/sis/init301.c
@@ -848,9 +848,7 @@ SiS_PanelDelay(struct SiS_Private *SiS_Pr, unsigned short DelayTime)
SiS_DDC2Delay(SiS_Pr, 0x4000);
}
- } else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
- (SiS_Pr->SiS_CustomT = CUT_COMPAQ1280) ||
- (SiS_Pr->SiS_CustomT = CUT_CLEVO1400) */ ) { /* 315 series, LVDS; Special */
+ } else if (SiS_Pr->SiS_IF_DEF_LVDS = 1) { /* 315 series, LVDS; Special */
if(SiS_Pr->SiS_IF_DEF_CH70xx = 0) {
PanelID = SiS_GetReg(SiS_Pr->SiS_P3d4,0x36);
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code
2018-09-20 20:22 ` [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code Nathan Chancellor
@ 2018-10-08 10:51 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-10-08 10:51 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Thomas Winischhofer, dri-devel, linux-fbdev, linux-kernel
On 09/20/2018 10:22 PM, Nathan Chancellor wrote:
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> } else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
> ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous
> parentheses around the comparison to silence this warning
> } else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
> ~ ^ ~
> drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this
> equality comparison into an assignment
> } else if((SiS_Pr->SiS_IF_DEF_LVDS = 1) /* ||
> ^~
> > 1 warning generated.
>
> Remove the parentheses and while we're at it, clean up the commented
> code, which has been here since the beginning of git history.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/118
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-08 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180920202232epcas2p115e690a9ab4b8d70c2c710addb8fbb1e@epcas2p1.samsung.com>
2018-09-20 20:22 ` [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code Nathan Chancellor
2018-10-08 10:51 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).