From: Christoph Hellwig <hch@lst.de>
To: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org,
alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] firmware: tegra: don't pass GFP_DMA32 to dma_alloc_coherent
Date: Sat, 13 Oct 2018 15:17:01 +0000 [thread overview]
Message-ID: <20181013151707.32210-3-hch@lst.de> (raw)
In-Reply-To: <20181013151707.32210-1-hch@lst.de>
The DMA API does its own zone decisions based on the coherent_dma_mask.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/firmware/tegra/bpmp-debugfs.c | 11 +++++------
drivers/firmware/tegra/bpmp.c | 2 +-
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/firmware/tegra/bpmp-debugfs.c b/drivers/firmware/tegra/bpmp-debugfs.c
index f7f6a0a5cb07..567160897bac 100644
--- a/drivers/firmware/tegra/bpmp-debugfs.c
+++ b/drivers/firmware/tegra/bpmp-debugfs.c
@@ -218,12 +218,12 @@ static int debugfs_show(struct seq_file *m, void *p)
return -ENOENT;
namevirt = dma_alloc_coherent(bpmp->dev, namesize, &namephys,
- GFP_KERNEL | GFP_DMA32);
+ GFP_KERNEL);
if (!namevirt)
return -ENOMEM;
datavirt = dma_alloc_coherent(bpmp->dev, datasize, &dataphys,
- GFP_KERNEL | GFP_DMA32);
+ GFP_KERNEL);
if (!datavirt) {
ret = -ENOMEM;
goto free_namebuf;
@@ -269,12 +269,12 @@ static ssize_t debugfs_store(struct file *file, const char __user *buf,
return -ENOENT;
namevirt = dma_alloc_coherent(bpmp->dev, namesize, &namephys,
- GFP_KERNEL | GFP_DMA32);
+ GFP_KERNEL);
if (!namevirt)
return -ENOMEM;
datavirt = dma_alloc_coherent(bpmp->dev, datasize, &dataphys,
- GFP_KERNEL | GFP_DMA32);
+ GFP_KERNEL);
if (!datavirt) {
ret = -ENOMEM;
goto free_namebuf;
@@ -422,8 +422,7 @@ int tegra_bpmp_init_debugfs(struct tegra_bpmp *bpmp)
if (!root)
return -ENOMEM;
- virt = dma_alloc_coherent(bpmp->dev, sz, &phys,
- GFP_KERNEL | GFP_DMA32);
+ virt = dma_alloc_coherent(bpmp->dev, sz, &phys, GFP_KERNEL);
if (!virt) {
ret = -ENOMEM;
goto out;
diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
index 14a456afa379..e6d2356ccec3 100644
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -531,7 +531,7 @@ static int tegra_bpmp_get_firmware_tag(struct tegra_bpmp *bpmp, char *tag,
int err;
virt = dma_alloc_coherent(bpmp->dev, MSG_DATA_MIN_SZ, &phys,
- GFP_KERNEL | GFP_DMA32);
+ GFP_KERNEL);
if (!virt)
return -ENOMEM;
--
2.19.1
next prev parent reply other threads:[~2018-10-13 15:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 15:16 remove bogus GFP_DMA32 flags for dma allocations Christoph Hellwig
2018-10-13 15:17 ` [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-15 7:43 ` Rafael J. Wysocki
2018-10-17 7:19 ` Christoph Hellwig
2018-10-17 7:22 ` Rafael J. Wysocki
2018-10-13 15:17 ` Christoph Hellwig [this message]
2018-10-13 15:17 ` [PATCH 3/8] spi: pic32-sqi: " Christoph Hellwig
2018-10-17 11:55 ` Applied "spi: pic32-sqi: don't pass GFP_DMA32 to dma_alloc_coherent" to the spi tree Mark Brown
2018-10-13 15:17 ` [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-13 16:18 ` [alsa-devel] " Takashi Iwai
2018-10-13 16:35 ` Christoph Hellwig
2018-10-13 18:10 ` Takashi Iwai
2018-10-13 15:17 ` [PATCH 5/8] sound: intel/sst: " Christoph Hellwig
2018-10-13 16:20 ` [alsa-devel] " Takashi Iwai
2018-10-17 11:54 ` Applied "ASoC: intel: don't pass GFP_DMA32 to dma_alloc_coherent" to the asoc tree Mark Brown
2018-10-13 15:17 ` [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard
2018-10-16 12:41 ` Benjamin Gaignard
2018-10-17 7:19 ` Christoph Hellwig
2018-10-18 11:59 ` Benjamin Gaignard
2018-10-13 15:17 ` [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard
2018-10-17 7:20 ` Christoph Hellwig
2018-10-18 12:00 ` Benjamin Gaignard
2018-12-05 10:31 ` Mauro Carvalho Chehab
2018-10-13 15:17 ` [PATCH 8/8] fsl-diu-fb: don't pass GFP_DMA32 to dmam_alloc_coherent Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013151707.32210-3-hch@lst.de \
--to=hch@lst.de \
--cc=alsa-devel@alsa-project.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).