From: Aleksa Zdravkovic <alex.zdravkovic98@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH] staging: sm750fb: Replace CamelCase variable names with underscores
Date: Tue, 23 Oct 2018 20:35:12 +0000 [thread overview]
Message-ID: <20181023203508.GA3951@zdravcePC> (raw)
Change variable names devId and revId to dev_id and rev_id
to meet linux kernel coding style. Issue found by checkpatch.
Signed-off-by: Aleksa Zdravkovic <alex.zdravkovic98@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 4c1f00f551da..6bdf643707c2 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -15,14 +15,14 @@ enum logical_chip_type sm750_get_chip_type(void)
return chip;
}
-void sm750_set_chip_type(unsigned short devId, u8 revId)
+void sm750_set_chip_type(unsigned short dev_id, u8 rev_id)
{
- if (devId = 0x718) {
+ if (dev_id = 0x718) {
chip = SM718;
- } else if (devId = 0x750) {
+ } else if (dev_id = 0x750) {
chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
- if (revId = SM750LE_REVISION_ID) {
+ if (rev_id = SM750LE_REVISION_ID) {
chip = SM750LE;
pr_info("found sm750le\n");
}
--
2.19.1
reply other threads:[~2018-10-23 20:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023203508.GA3951@zdravcePC \
--to=alex.zdravkovic98@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).