From: Greg KH <gregkh@linuxfoundation.org>
To: Amanoel Dawod <amanoel@amanoeldawod.com>
Cc: akpm@linux-foundation.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fonts: New Terminus large console font
Date: Mon, 26 Nov 2018 08:14:32 +0000 [thread overview]
Message-ID: <20181126081432.GA30722@kroah.com> (raw)
In-Reply-To: <CACd_pd8o5vA85ppNp3hzm+awBvwq6VEONij6rHAPExmPfjaWRA@mail.gmail.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Nov 26, 2018 at 03:09:31AM -0500, Amanoel Dawod wrote:
> Changing the name did not break anything. Pretty much I dumped the original
> .psf file to .inc
> format with new naming using psftools extracting the bitmap data. Then
> manually editing it
> removing useless header, leaving bitmaps data alone.
I did not refer to any name, just the #define that you changed.
> Do you mean adding it at end of lists with other fonts? if that's what you
> mean,
> no real reason, but just wanted it to be after sun12x22 always as in
> Kconfig.
You can put it wherever you want in the Kconfig file (but you should put
it at the end, as it is a new font.) I mean the #defines, you need to
just add it at the end please, do not change any existing #defines.
> Please let me know if that must be changed.
> Now regarding "From:" line, please accept my apology as it my first time
> dealing
> with submissions and git send-mail. Should I re-submit the patch with
> modified subject line?
Not subject line, From: line from your email client. And you need to
change the patch anyway before it could be added, so you have to resend
it :)
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-26 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181126034734.9423-1-amanoeladawod@gmail.com>
2018-11-26 6:56 ` [PATCH] Fonts: New Terminus large console font Greg KH
[not found] ` <CACd_pd8o5vA85ppNp3hzm+awBvwq6VEONij6rHAPExmPfjaWRA@mail.gmail.com>
2018-11-26 8:14 ` Greg KH [this message]
2018-11-26 6:57 ` Greg KH
2018-11-27 13:24 ` Lubomir Rintel
[not found] <20181126092115.754-1-amanoeladawod@gmail.com>
2018-12-05 11:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126081432.GA30722@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=amanoel@amanoeldawod.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).