linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Prarit Bhargava <prarit@redhat.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Yisheng Xie <ysxie@foxmail.com>,
	linux-fbdev@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Steven Rostedt <rostedt@goodmis.org>,
	Marko Myllynen <myllynen@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>,
	dri-devel@lists.freedesktop.org,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v3] fbcon: Silence fbcon logo on 'quiet' boots
Date: Mon, 07 Jan 2019 10:09:42 +0000	[thread overview]
Message-ID: <20190107100942.GA11039@jagdpanzerIV> (raw)
In-Reply-To: <3de54c0d-3e9b-769f-5cc6-e69dbb399426@samsung.com>

On (12/20/18 17:31), Bartlomiej Zolnierkiewicz wrote:
[..]
> > +++ b/kernel/printk/printk.c
> > @@ -66,6 +66,7 @@ int console_printk[4] = {
> >  	CONSOLE_LOGLEVEL_MIN,		/* minimum_console_loglevel */
> >  	CONSOLE_LOGLEVEL_DEFAULT,	/* default_console_loglevel */
> >  };
> > +EXPORT_SYMBOL(console_printk);
> 
> You need printk Maintainers Ack on it.

I would prefer this to be in a separate patch, probably.

Exporting (I think EXPORT_SYMBOL_GPL would be better) console_printk[4]
seems to be the simplest solution.

Alternatively, we can have a new fbcon function which would be called
from quiet_kernel() and would set logo_shown accordingly.

	-ss

  parent reply	other threads:[~2019-01-07 10:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181030154456epcas4p19e91c78daad3f1f48e8260601e5fdfec@epcas4p1.samsung.com>
2018-10-30 15:44 ` [PATCH v3] fbcon: Silence fbcon logo on 'quiet' boots Prarit Bhargava
2018-10-30 21:35   ` Steven Rostedt
2018-10-30 21:35   ` Steven Rostedt
2018-10-30 22:31     ` Prarit Bhargava
2018-12-20 16:31   ` Bartlomiej Zolnierkiewicz
2019-01-02 16:05     ` Petr Mladek
2019-01-03 10:38       ` Geert Uytterhoeven
2019-01-10 18:46       ` Prarit Bhargava
2019-01-07 10:09     ` Sergey Senozhatsky [this message]
2019-01-10 19:03   ` [PATCH v4 0/2] Do not output logo on quiet boots Prarit Bhargava
2019-01-10 19:03     ` [PATCH v4 1/2] fbcon: Silence fbcon logo on 'quiet' boots Prarit Bhargava
2019-01-11  6:04       ` Sergey Senozhatsky
2019-01-15 15:09         ` Petr Mladek
2019-01-10 19:03     ` [PATCH v4 2/2] printk: Export console_printk Prarit Bhargava
2019-01-11  6:02       ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107100942.GA11039@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=myllynen@redhat.com \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=treding@nvidia.com \
    --cc=ysxie@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).