From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 15 Jan 2019 15:02:31 +0000 Subject: Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface Message-Id: <20190115150231.GA3418@kroah.com> List-Id: References: <20190115044704.GA20989@nishad> In-Reply-To: <20190115044704.GA20989@nishad> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nishad Kamdar Cc: devel@driverdev.osuosl.org, Leonardo =?iso-8859-1?Q?Br=E1s?= , linux-fbdev@vger.kernel.org, Jani Nikula , Daniel Vetter , Felix Siegel , YueHaibing , linux-kernel@vger.kernel.org, Mamta Shukla , Matthias Wolf , Renato Soma , dri-devel@lists.freedesktop.org, Tim Cofala , Radek =?iso-8859-1?Q?Dost=E1l?= , Lee Jones On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote: > This switches the fbtft driver to use GPIO descriptors > rather than numerical gpios: > > Utilize the GPIO library's intrinsic handling of OF GPIOs > and polarity. If the line is flagged active low, gpiolib > will deal with this. > > Remove gpios from platform device structure. Neither assign > statically numbers to gpios in platform device nor allow > gpios to be parsed as module parameters. > > Signed-off-by: Nishad Kamdar > Changes in v2: > - Merge all patches in a single patch. This is because the > first patch changes par->gpio from an int to a pointer > so all the checks have to be updated in the same patch. > Otherwie it breaks 'git bisect'. The "v2" information goes below the --- line please. Also, I got 2 copies of this, both different, so I have no idea which to apply. Please fix up and resend a v3. thanks, greg k-h