From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dante Paz <dante.paz@gmail.com>
Cc: devel@driverdev.osuosl.org, Dante Paz <dpaz@unc.edu.ar>,
linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
leobras.c@gmail.com, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, renatoys08@gmail.com
Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems
Date: Mon, 11 Mar 2019 08:11:27 +0000 [thread overview]
Message-ID: <20190311081127.GC2434@kadam> (raw)
In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com>
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote:
> From: Dante Paz <dpaz@unc.edu.ar>
>
> Style and coding function issues were corrected, by avoiding macro functions with a conflicting coding style.
> Signed-off-by: Dante Paz <dpaz@unc.edu.ar>
Line too long. No blank. Fix indenting.
It's not really clear what you're trying to do actually... You need to
sell your patch a bit to try convince us that it's worth applying.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-11 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 21:48 [PATCH] FBTFT: fbtft-bus: Fix code style problems Dante Paz
2019-03-11 8:11 ` Dan Carpenter [this message]
2019-03-11 8:18 ` Dan Carpenter
2019-03-11 16:25 ` Sam Ravnborg
2019-03-11 20:32 ` DANTE JAVIER PAZ
2019-03-11 21:15 ` Ezequiel Garcia
2019-03-11 21:40 ` Sam Ravnborg
2019-03-11 21:43 ` Ezequiel Garcia
2019-03-11 21:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311081127.GC2434@kadam \
--to=dan.carpenter@oracle.com \
--cc=dante.paz@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dpaz@unc.edu.ar \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=leobras.c@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=renatoys08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox