From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 20 Mar 2019 12:36:23 +0000 Subject: Re: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl(). Message-Id: <20190320123622.GH2202@kadam> List-Id: References: <20190303165532.23727-1-tomli@tomli.me> <20190303165532.23727-3-tomli@tomli.me> In-Reply-To: <20190303165532.23727-3-tomli@tomli.me> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yifeng Li Cc: Jiri Kosina , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Jin Chen , Sudip Mukherjee , Teddy Wang On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote: > Rename the function setDisplayControl() to set_display_control(). > This fixes the following checkpatch.pl warning: > > CHECK: Avoid CamelCase: > > Suggested-by: Jin Chen > Signed-off-by: Jin Chen > [tomli@tomli.me: resent as trivial patch, reworded the commit message] > Signed-off-by: Yifeng Li > --- Apparently Greg already applied this earlier... I don't know why the original patch didn't reach me. I'm on the devel@driverdev.osuosl.org list. Did Jin Chen write this? If so why does it have a Suggested-by tag for him? If not then you should have preserved the authorship credit by using the From: header in the first line on the commit message... Anyway, it doesn't matter but hopefully this helps for next time. regards, dan carpenter