linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: kbuild-all@01.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: da8xx-fb: add COMPILE_TEST support
Date: Tue, 16 Apr 2019 06:29:33 +0000	[thread overview]
Message-ID: <201904161412.VEAizQ2O%lkp@intel.com> (raw)
In-Reply-To: <5eba3c36-bc65-74ae-cc7c-cc45ee06ccfe@samsung.com>

Hi Bartlomiej,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc5 next-20190415]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/video-fbdev-da8xx-fb-add-COMPILE_TEST-support/20190415-184308
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)


vim +1159 drivers/video/fbdev/da8xx-fb.c

1f9c3e1f drivers/video/da8xx-fb.c Martin Ambrose        2010-05-24  1144  
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1145  static int fb_ioctl(struct fb_info *info, unsigned int cmd,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1146  			  unsigned long arg)
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1147  {
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1148  	struct lcd_sync_arg sync_arg;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1149  
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1150  	switch (cmd) {
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1151  	case FBIOGET_CONTRAST:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1152  	case FBIOPUT_CONTRAST:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1153  	case FBIGET_BRIGHTNESS:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1154  	case FBIPUT_BRIGHTNESS:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1155  	case FBIGET_COLOR:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1156  	case FBIPUT_COLOR:
2f93e8f4 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1157  		return -ENOTTY;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1158  	case FBIPUT_HSYNC:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22 @1159  		if (copy_from_user(&sync_arg, (char *)arg,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1160  				sizeof(struct lcd_sync_arg)))
2f93e8f4 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1161  			return -EFAULT;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1162  		lcd_cfg_horizontal_sync(sync_arg.back_porch,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1163  					sync_arg.pulse_width,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1164  					sync_arg.front_porch);
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1165  		break;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1166  	case FBIPUT_VSYNC:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1167  		if (copy_from_user(&sync_arg, (char *)arg,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1168  				sizeof(struct lcd_sync_arg)))
2f93e8f4 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1169  			return -EFAULT;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1170  		lcd_cfg_vertical_sync(sync_arg.back_porch,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1171  					sync_arg.pulse_width,
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1172  					sync_arg.front_porch);
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1173  		break;
1f9c3e1f drivers/video/da8xx-fb.c Martin Ambrose        2010-05-24  1174  	case FBIO_WAITFORVSYNC:
1f9c3e1f drivers/video/da8xx-fb.c Martin Ambrose        2010-05-24  1175  		return fb_wait_for_vsync(info);
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1176  	default:
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1177  		return -EINVAL;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1178  	}
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1179  	return 0;
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1180  }
4ed824d9 drivers/video/da8xx-fb.c Sudhakar Rajashekhara 2009-09-22  1181  

:::::: The code at line 1159 was first introduced by commit
:::::: 4ed824d9aead77a6a4eb1e89c3b3d270ba386fad davinci: fb: Frame Buffer driver for TI DA8xx/OMAP-L1xx

:::::: TO: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

      reply	other threads:[~2019-04-16  6:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190412115855eucas1p13b364b5e815ccd338ceb74577d116b14@eucas1p1.samsung.com>
2019-04-12 11:58 ` [PATCH] video: fbdev: da8xx-fb: add COMPILE_TEST support Bartlomiej Zolnierkiewicz
2019-04-16  6:29   ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201904161412.VEAizQ2O%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).