From: Brian Masney <masneyb@onstation.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dmurphy@ti.com, jonathan@marek.ca,
Daniel Thompson <daniel@redfelineninja.org.uk>
Subject: Re: [PATCH v6 3/3] backlight: lm3630a: add firmware node support
Date: Thu, 02 May 2019 10:46:12 +0000 [thread overview]
Message-ID: <20190502104612.GB24563@basecamp> (raw)
In-Reply-To: <3d8a2f9e-bd41-7713-5ad4-05a0d71e8fb1@linaro.org>
On Thu, May 02, 2019 at 11:19:50AM +0100, Daniel Thompson wrote:
> On 24/04/2019 10:25, Brian Masney wrote:
> > Add fwnode support to the lm3630a driver and optionally allow
> > configuring the label, default brightness level, and maximum brightness
> > level. The two outputs can be controlled by bank A and B independently
> > or bank A can control both outputs.
> >
> > If the platform data was not configured, then the driver defaults to
> > enabling both banks. This patch changes the default value to disable
> > both banks before parsing the firmware node so that just a single bank
> > can be enabled if desired. There are no in-tree users of this driver.
>
> In that case given I'd certainly entertain patches that move the config
> structures out of include/linux/platform_data and say the driver requires a
> proper entry in the hardware description! Not a requirement though.
OK, I'll submit patches for that after this series is merged.
Brian
prev parent reply other threads:[~2019-05-02 10:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 9:25 [PATCH v6 0/3] backlight: lm3630a: bug fix and fwnode support Brian Masney
2019-04-24 9:25 ` [PATCH v6 1/3] backlight: lm3630a: return 0 on success in update_status functions Brian Masney
2019-05-02 10:07 ` Daniel Thompson
2019-05-02 10:42 ` Brian Masney
2019-05-02 10:46 ` Daniel Thompson
2019-05-07 9:53 ` Lee Jones
2019-04-24 9:25 ` [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings Brian Masney
2019-04-24 14:20 ` Pavel Machek
2019-04-24 15:57 ` Rob Herring
2019-04-24 18:55 ` Pavel Machek
2019-05-02 10:09 ` Daniel Thompson
2019-05-17 21:11 ` Rob Herring
2019-05-17 23:12 ` Brian Masney
2019-04-24 9:25 ` [PATCH v6 3/3] backlight: lm3630a: add firmware node support Brian Masney
2019-04-24 14:24 ` Pavel Machek
2019-05-02 10:19 ` Daniel Thompson
2019-05-02 10:46 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502104612.GB24563@basecamp \
--to=masneyb@onstation.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel@redfelineninja.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonathan@marek.ca \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).