From: Christoph Hellwig <hch@lst.de>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Michal Simek <monstr@monstr.eu>, James Hogan <jhogan@kernel.org>,
linux-mips@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
linux-kernel@vger.kernel.org, Paul Burton <paul.burton@mips.com>,
iommu@lists.linux-foundation.org, linux-fbdev@vger.kernel.org,
Ley Foon Tan <lftan@altera.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/7] au1100fb: fix DMA API abuse
Date: Tue, 07 May 2019 06:36:18 +0000 [thread overview]
Message-ID: <20190507063618.GA28147@lst.de> (raw)
In-Reply-To: <7a63eeae-4ec3-c82e-c497-8adc7bcb3cea@samsung.com>
On Mon, May 06, 2019 at 03:49:35PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On 04/30/2019 01:00 PM, Christoph Hellwig wrote:
> > Virtual addresses return from dma(m)_alloc_coherent are opaque in what
> > backs then, and drivers must not poke into them. Switch the driver
> > to use the generic DMA API mmap helper to avoid these games.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Given this actually fixes issues with the current driver, what do you
think of taking it for 5.2 through your tree? Also au1200fb has
basically the same issues, just without abusing the CAC_ADDR helper,
I could send you a patch for that one as well.
next prev parent reply other threads:[~2019-05-07 6:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 11:00 provide generic support for uncached segements in dma-direct Christoph Hellwig
2019-04-30 11:00 ` [PATCH 1/7] MIPS: remove the _dma_cache_wback_inv export Christoph Hellwig
2019-04-30 11:00 ` [PATCH 2/7] au1100fb: fix DMA API abuse Christoph Hellwig
2019-05-06 13:49 ` Bartlomiej Zolnierkiewicz
2019-05-07 6:36 ` Christoph Hellwig [this message]
2019-06-03 6:49 ` Christoph Hellwig
2019-04-30 11:00 ` [PATCH 3/7] dma-mapping: add a Kconfig symbol to indicate arch_dma_prep_coherent presence Christoph Hellwig
2019-04-30 11:00 ` [PATCH 4/7] dma-direct: provide generic support for uncached kernel segments Christoph Hellwig
2019-05-01 17:18 ` Paul Burton
2019-05-01 17:29 ` Christoph Hellwig
2019-05-01 17:40 ` Paul Burton
2019-05-01 17:49 ` Christoph Hellwig
2019-05-02 0:08 ` Paul Burton
2019-05-02 13:11 ` Christoph Hellwig
2019-04-30 11:00 ` [PATCH 5/7] MIPS: use the generic uncached segment support in dma-direct Christoph Hellwig
2019-04-30 20:10 ` Paul Burton
2019-04-30 20:29 ` Christoph Hellwig
2019-04-30 21:11 ` Paul Burton
2019-04-30 21:15 ` Christoph Hellwig
2019-05-01 13:13 ` [PATCH 5/7 v2] " Christoph Hellwig
2019-05-01 17:13 ` Paul Burton
2019-06-03 6:48 ` Christoph Hellwig
2019-07-03 8:54 ` Arnd Bergmann
2019-07-03 12:13 ` Christoph Hellwig
2019-04-30 11:00 ` [PATCH 6/7] nios2: " Christoph Hellwig
2019-04-30 11:00 ` [PATCH 7/7] microblaze: " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507063618.GA28147@lst.de \
--to=hch@lst.de \
--cc=b.zolnierkie@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jhogan@kernel.org \
--cc=lftan@altera.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).