From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 07 May 2019 06:36:18 +0000 Subject: Re: [PATCH 2/7] au1100fb: fix DMA API abuse Message-Id: <20190507063618.GA28147@lst.de> List-Id: References: <20190430110032.25301-1-hch@lst.de> <20190430110032.25301-3-hch@lst.de> <7a63eeae-4ec3-c82e-c497-8adc7bcb3cea@samsung.com> In-Reply-To: <7a63eeae-4ec3-c82e-c497-8adc7bcb3cea@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: Michal Simek , James Hogan , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , iommu@lists.linux-foundation.org, linux-fbdev@vger.kernel.org, Ley Foon Tan , Christoph Hellwig On Mon, May 06, 2019 at 03:49:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 04/30/2019 01:00 PM, Christoph Hellwig wrote: > > Virtual addresses return from dma(m)_alloc_coherent are opaque in what > > backs then, and drivers must not poke into them. Switch the driver > > to use the generic DMA API mmap helper to avoid these games. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Bartlomiej Zolnierkiewicz Given this actually fixes issues with the current driver, what do you think of taking it for 5.2 through your tree? Also au1200fb has basically the same issues, just without abusing the CAC_ADDR helper, I could send you a patch for that one as well.