From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org,
"DRI Development" <dri-devel@lists.freedesktop.org>,
linux-fbdev@vger.kernel.org,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Mikulas Patocka" <mpatocka@redhat.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Peter Rosin" <peda@axentia.se>
Subject: Re: [Intel-gfx] [PATCH 18/33] fbdev: make unregister/unlink functions not fail
Date: Mon, 20 May 2019 21:45:53 +0000 [thread overview]
Message-ID: <201905210520.GS4ztecg%lkp@intel.com> (raw)
In-Reply-To: <20190520082216.26273-19-daniel.vetter@ffwll.ch>
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc1 next-20190520]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-notifier-begone/20190521-021841
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/staging/fbtft/fbtft-core.c:894:38: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got vint @@
>> drivers/staging/fbtft/fbtft-core.c:894:38: sparse: expected int
>> drivers/staging/fbtft/fbtft-core.c:894:38: sparse: got void
--
>> drivers/media/pci/ivtv/ivtvfb.c:1261:43: sparse: sparse: incorrect type in conditional (non-scalar type)
>> drivers/media/pci/ivtv/ivtvfb.c:1261:43: sparse: got void
--
>> drivers/video/fbdev/neofb.c:2130:43: sparse: sparse: incorrect type in conditional (non-scalar type)
>> drivers/video/fbdev/neofb.c:2130:43: sparse: got void
--
>> drivers/video/fbdev/savage/savagefb_driver.c:2341:43: sparse: sparse: incorrect type in conditional (non-scalar type)
>> drivers/video/fbdev/savage/savagefb_driver.c:2341:43: sparse: got void
vim +894 drivers/staging/fbtft/fbtft-core.c
c296d5f9 Thomas Petazzoni 2014-12-31 877
c296d5f9 Thomas Petazzoni 2014-12-31 878 /**
c296d5f9 Thomas Petazzoni 2014-12-31 879 * fbtft_unregister_framebuffer - releases a tft frame buffer device
c296d5f9 Thomas Petazzoni 2014-12-31 880 * @fb_info: frame buffer info structure
c296d5f9 Thomas Petazzoni 2014-12-31 881 *
c296d5f9 Thomas Petazzoni 2014-12-31 882 * Frees SPI driverdata if needed
c296d5f9 Thomas Petazzoni 2014-12-31 883 * Frees gpios.
c296d5f9 Thomas Petazzoni 2014-12-31 884 * Unregisters frame buffer device.
c296d5f9 Thomas Petazzoni 2014-12-31 885 *
c296d5f9 Thomas Petazzoni 2014-12-31 886 */
c296d5f9 Thomas Petazzoni 2014-12-31 887 int fbtft_unregister_framebuffer(struct fb_info *fb_info)
c296d5f9 Thomas Petazzoni 2014-12-31 888 {
c296d5f9 Thomas Petazzoni 2014-12-31 889 struct fbtft_par *par = fb_info->par;
c296d5f9 Thomas Petazzoni 2014-12-31 890
c296d5f9 Thomas Petazzoni 2014-12-31 891 if (par->fbtftops.unregister_backlight)
c296d5f9 Thomas Petazzoni 2014-12-31 892 par->fbtftops.unregister_backlight(par);
c296d5f9 Thomas Petazzoni 2014-12-31 893 fbtft_sysfs_exit(par);
11107ffe Aya Mahfouz 2015-02-27 @894 return unregister_framebuffer(fb_info);
c296d5f9 Thomas Petazzoni 2014-12-31 895 }
c296d5f9 Thomas Petazzoni 2014-12-31 896 EXPORT_SYMBOL(fbtft_unregister_framebuffer);
c296d5f9 Thomas Petazzoni 2014-12-31 897
:::::: The code at line 894 was first introduced by commit
:::::: 11107ffe2cd1c1dc5948713fc08a1372185be0d5 staging: fbtft: remove unused variable
:::::: TO: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-05-20 21:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190520082216.26273-1-daniel.vetter@ffwll.ch>
2019-05-20 8:21 ` [PATCH 07/33] fbdev/aty128fb: Remove dead code Daniel Vetter
2019-05-20 8:21 ` [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly Daniel Vetter
2019-05-20 8:33 ` Thomas Zimmermann
2019-05-20 8:37 ` Thomas Zimmermann
2019-05-21 15:09 ` Daniel Vetter
2019-05-20 17:08 ` Sam Ravnborg
2019-05-20 17:25 ` Daniel Vetter
2019-05-20 8:21 ` [PATCH 16/33] fbdev: lock_fb_info cannot fail Daniel Vetter
2019-05-20 8:22 ` [PATCH 17/33] fbcon: call fbcon_fb_bind directly Daniel Vetter
2019-05-20 8:22 ` [PATCH 18/33] fbdev: make unregister/unlink functions not fail Daniel Vetter
2019-05-20 19:08 ` [Intel-gfx] " kbuild test robot
2019-05-20 19:25 ` kbuild test robot
2019-05-20 21:45 ` kbuild test robot [this message]
2019-05-20 8:22 ` [PATCH 21/33] fbdev: directly call fbcon_suspended/resumed Daniel Vetter
2019-05-20 19:24 ` kbuild test robot
2019-05-20 8:22 ` [PATCH 22/33] fbcon: Call fbcon_mode_deleted/new_modelist directly Daniel Vetter
2019-05-20 8:22 ` [PATCH 23/33] fbdev: Call fbcon_get_requirement directly Daniel Vetter
2019-05-20 8:22 ` [PATCH 24/33] Revert "backlight/fbcon: Add FB_EVENT_CONBLANK" Daniel Vetter
2019-05-20 8:22 ` [PATCH 29/33] fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls Daniel Vetter
2019-05-21 10:56 ` Maarten Lankhorst
2019-05-21 12:42 ` Daniel Vetter
2019-05-20 8:22 ` [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly Daniel Vetter
2019-05-20 8:37 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905210520.GS4ztecg%lkp@intel.com \
--to=lkp@intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpatocka@redhat.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).