From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Date: Thu, 23 May 2019 17:12:37 +0000 Subject: Re: [PATCH] drm/edid: Fix docbook in drm_hdmi_infoframe_set_hdr_metadata() Message-Id: <20190523171237.GD17077@art_vandelay> List-Id: References: <20190523135504.184354-1-sean@poorly.run> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: "Shankar, Uma" Cc: "linux-fbdev@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Maxime Ripard , "dri-devel@lists.freedesktop.org" , Hans Verkuil , David Airlie , Sean Paul , Sean Paul On Thu, May 23, 2019 at 02:38:37PM +0000, Shankar, Uma wrote: >=20 >=20 > >-----Original Message----- > >From: Sean Paul [mailto:sean@poorly.run] > >Sent: Thursday, May 23, 2019 7:25 PM > >To: dri-devel@lists.freedesktop.org > >Cc: Sean Paul ; Shankar, Uma ; > >Sharma, Shashank ; Ville Syrj=E4l=E4 > >; Maarten Lankhorst > >; Maxime Ripard > >; Sean Paul ; David Airlie > >; Daniel Vetter ; Bartlomiej Zolnierk= iewicz > >; Hans Verkuil ; linux- > >fbdev@vger.kernel.org > >Subject: [PATCH] drm/edid: Fix docbook in drm_hdmi_infoframe_set_hdr_met= adata() > > > >From: Sean Paul > > > >Fixes the following warnings: > >../drivers/gpu/drm/drm_edid.c:4925: warning: Function parameter or member > >'conn_state' not described in 'drm_hdmi_infoframe_set_hdr_metadata' > >../drivers/gpu/drm/drm_edid.c:4925: warning: Excess function parameter > >'hdr_metadata' description in 'drm_hdmi_infoframe_set_hdr_metadata' >=20 > Thanks Sean Paul for fixing this. > Reviewed-by: Uma Shankar Pushed to -misc-next, thank you for the review! Sean >=20 > >Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support") > >Cc: Uma Shankar > >Cc: Shashank Sharma > >Cc: Ville Syrj=E4l=E4 > >Cc: Maarten Lankhorst > >Cc: Maxime Ripard > >Cc: Sean Paul > >Cc: David Airlie > >Cc: Daniel Vetter > >Cc: Bartlomiej Zolnierkiewicz > >Cc: "Ville Syrj=E4l=E4" > >Cc: Hans Verkuil > >Cc: dri-devel@lists.freedesktop.org > >Cc: linux-fbdev@vger.kernel.org > >Signed-off-by: Sean Paul > >--- > > drivers/gpu/drm/drm_edid.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c ind= ex > >262510c2a670..d87f574feeca 100644 > >--- a/drivers/gpu/drm/drm_edid.c > >+++ b/drivers/gpu/drm/drm_edid.c > >@@ -4914,7 +4914,7 @@ static inline bool is_eotf_supported(u8 output_eot= f, u8 > >sink_eotf) > > * drm_hdmi_infoframe_set_hdr_metadata() - fill an HDMI DRM infoframe w= ith > > * HDR metadata from userspace > > * @frame: HDMI DRM infoframe > >- * @hdr_metadata: hdr_source_metadata info from userspace > >+ * @conn_state: Connector state containing HDR metadata > > * > > * Return: 0 on success or a negative error code on failure. > > */ > >-- > >Sean Paul, Software Engineer, Google / Chromium OS >=20 --=20 Sean Paul, Software Engineer, Google / Chromium OS