From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Sat, 01 Jun 2019 21:06:51 +0000 Subject: Re: [PATCH v3] video: fbdev: atmel_lcdfb: add COMPILE_TEST support Message-Id: <20190601210651.GB3558@piout.net> List-Id: References: <69cd6b8b-1fd1-86fa-2070-99d0ce15a868@samsung.com> In-Reply-To: <69cd6b8b-1fd1-86fa-2070-99d0ce15a868@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: Nicolas Ferre , Ludovic Desroches , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 30/05/2019 14:30:19+0200, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to atmel_lcdfb driver for better compile > testing coverage. > > While at it fix improper use of UL (to silence build warnings on > x86_64). > > Cc: Alexandre Belloni Acked-by: Alexandre Belloni > Cc: Ludovic Desroches > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > v3: fix build warnings on x86_64 Hopefully, no building errors anymore ;) > > v2: add missing HAVE_CLK && HAS IOMEM dependencies > > drivers/video/fbdev/Kconfig | 3 ++- > drivers/video/fbdev/atmel_lcdfb.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > Index: b/drivers/video/fbdev/Kconfig > =================================> --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -855,7 +855,8 @@ config FB_S1D13XXX > > config FB_ATMEL > tristate "AT91 LCD Controller support" > - depends on FB && OF && HAVE_FB_ATMEL > + depends on FB && OF && HAVE_CLK && HAS_IOMEM > + depends on HAVE_FB_ATMEL || COMPILE_TEST > select FB_BACKLIGHT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > Index: b/drivers/video/fbdev/atmel_lcdfb.c > =================================> --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -673,7 +673,7 @@ static int atmel_lcdfb_set_par(struct fb > lcdc_writel(sinfo, ATMEL_LCDC_MVAL, 0); > > /* Disable all interrupts */ > - lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0UL); > + lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0U); > /* Enable FIFO & DMA errors */ > lcdc_writel(sinfo, ATMEL_LCDC_IER, ATMEL_LCDC_UFLWI | ATMEL_LCDC_OWRI | ATMEL_LCDC_MERI); > > @@ -1291,7 +1291,7 @@ static int atmel_lcdfb_suspend(struct pl > * We don't want to handle interrupts while the clock is > * stopped. It may take forever. > */ > - lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0UL); > + lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0U); > > sinfo->saved_lcdcon = lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_CTR); > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, 0); -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com