From: Matthias Kaehlcke <mka@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Douglas Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH 2/4] backlight: Expose brightness curve type through sysfs
Date: Thu, 13 Jun 2019 21:56:46 +0000 [thread overview]
Message-ID: <20190613215646.GO137143@google.com> (raw)
In-Reply-To: <20190613194326.180889-3-mka@chromium.org>
I noticed a few minor things when glancing over the patch on patchwork
On Thu, Jun 13, 2019 at 12:43:24PM -0700, Matthias Kaehlcke wrote:
> Backlight brightness curves can have different shapes. The two main
> types are linear and non-linear curves. The human eye doesn't
> perceive linearly increasing/decreasing brightness as linear (see
> also 88ba95bedb79 "backlight: pwm_bl: Compute brightness of LED
> linearly to human eye"), hence many backlights use non-linear (often
> logarithmic) brightness curves. The type of curve currently is opaque
> to userspace, so userspace often relies on more or less reliable
nit: avoid relies ... reliable :)
> heuristics (like the number of brightness levels) to decide whether
> to treat a backlight device as linear or non-linear.
>
> Export the type of the brightness curve via the new sysfs attribute
> 'scale'. The value of the attribute may be a simple string like
> 'linear' or 'non-linear', or a composite string similar to
> 'compatible' strings of the device tree. A composite string consists
> of different elements separated by commas, starting with the
> most-detailed description and ending with the least-detailed one. An
> example for a composite string is "cie-1931,perceptual,non-linear"
> This brightness curve was generated with the CIE 1931 algorithm, it
> is perceptually linear, but not actually linear in terms of the
> emitted light. If userspace doesn't know about 'cie-1931' or
> 'perceptual' it should at least be able to interpret the 'non-linear'
> part.
>
> For devices that don't provide information about the scale of their
> brightness curve the value of the 'scale' attribute is 'unknown'.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> .../ABI/testing/sysfs-class-backlight | 32 +++++++++++++++++++
> MAINTAINERS | 1 +
> drivers/video/backlight/backlight.c | 22 +++++++++++++
> include/linux/backlight.h | 10 ++++++
> 4 files changed, 65 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-backlight
>
> diff --git a/Documentation/ABI/testing/sysfs-class-backlight b/Documentation/ABI/testing/sysfs-class-backlight
> new file mode 100644
> index 000000000000..924fb68940e6
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-backlight
> @@ -0,0 +1,32 @@
> +What: /sys/class/backlight/<backlight>/scale
> +Date: June 2019
> +KernelVersion: 5.4
> +Contact: Daniel Thompson <daniel.thompson@linaro.org>
> +Description:
> + Description of the scale of the brightness curve. The
> + description consists of one or more elements separated by
> + commas, from the most detailed to the least detailed
> + description.
> +
> + Possible values are:
> +
> + unknown
> + The scale of the brightness curve is unknown.
> +
> + linear
> + The brightness changes linearly in terms of the emitted
> + light, changes are perceived as non-linear by the human eye.
> +
> + non-linear
> + The brightness changes non-linearly in terms of the emitted
> + light, changes might be perceived as linear by the human eye.
> +
> + perceptual,non-linear
> + The brightness changes non-linearly in terms of the emitted
> + light, changes should be perceived as linear by the human eye.
> +
> + cie-1931,perceptual,non-linear
> + The brightness curves was calculated with the CIE 1931
s/curves/curve/
> +static const char *const backlight_scale_types[] = {
> + [BACKLIGHT_SCALE_UNKNOWN] = "unknown",
> + [BACKLIGHT_SCALE_CIE1931] = "cie-1931,perceptual,non-linear",
> + [BACKLIGHT_SCALE_PERCEPTUAL] = "perceptual,non-linear",
> + [BACKLIGHT_SCALE_LINEAR] = "linear",
> + [BACKLIGHT_SCALE_NON_LINEAR] = "non-linear",
> +};
> +
> +
Delete one blank line
> +enum backlight_scale {
> + BACKLIGHT_SCALE_UNKNOWN,
> + BACKLIGHT_SCALE_CIE1931 = 1,
> + BACKLIGHT_SCALE_PERCEPTUAL,
> + BACKLIGHT_SCALE_LINEAR,
> + BACKLIGHT_SCALE_NON_LINEAR, /* needed for backwards compatibility */
maybe better list the more generic options first, same for the string
table.
next prev parent reply other threads:[~2019-06-13 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 19:43 [PATCH 0/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke
2019-06-13 19:43 ` [PATCH 1/4] MAINTAINERS: Add entry for stable backlight sysfs ABI documentation Matthias Kaehlcke
2019-06-19 11:05 ` Daniel Thompson
2019-06-13 19:43 ` [PATCH 2/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke
2019-06-13 21:56 ` Matthias Kaehlcke [this message]
2019-06-13 19:43 ` [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves Matthias Kaehlcke
2019-06-19 9:17 ` Enric Balletbo i Serra
2019-06-21 12:55 ` Daniel Thompson
2019-06-27 9:24 ` Lee Jones
2019-06-27 15:49 ` Daniel Thompson
2019-06-13 19:43 ` [PATCH 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT Matthias Kaehlcke
2019-06-21 13:10 ` Daniel Thompson
2019-06-24 18:54 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613215646.GO137143@google.com \
--to=mka@chromium.org \
--cc=b.zolnierkie@samsung.com \
--cc=briannorris@chromium.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).