* [PATCH] fbmem: remove redundant assignment to err @ 2019-06-24 22:37 ` Colin King 2019-07-23 15:35 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Colin King @ 2019-06-24 22:37 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Daniel Vetter, dri-devel, linux-fbdev Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> Variable err is initialized to a value that is never read and it is re-assigned later. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/video/fbdev/core/fbmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index dd1a708df1a7..ae044a1325ca 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -1987,7 +1987,7 @@ int fb_new_modelist(struct fb_info *info) struct list_head *pos, *n; struct fb_modelist *modelist; struct fb_videomode *m, mode; - int err = 1; + int err; list_for_each_safe(pos, n, &info->modelist) { modelist = list_entry(pos, struct fb_modelist, list); -- 2.20.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbmem: remove redundant assignment to err 2019-06-24 22:37 ` [PATCH] fbmem: remove redundant assignment to err Colin King @ 2019-07-23 15:35 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-07-23 15:35 UTC (permalink / raw) To: Colin King Cc: Daniel Vetter, linux-fbdev, kernel-janitors, linux-kernel, dri-devel On 6/25/19 12:37 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable err is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-23 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20190624223730epcas2p4d2b1ad1200c11a472ba327ee39ede08b@epcas2p4.samsung.com>
2019-06-24 22:37 ` [PATCH] fbmem: remove redundant assignment to err Colin King
2019-07-23 15:35 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).