From: Rob Herring <robh@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, jonathan@marek.ca,
b.zolnierkie@samsung.com, jingoohan1@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, lee.jones@linaro.org,
linux-leds@vger.kernel.org, dmurphy@ti.com
Subject: Re: [PATCH] dt-bindings: backlight: lm3630a: correct schema validation
Date: Fri, 28 Jun 2019 19:22:38 +0000 [thread overview]
Message-ID: <20190628192238.GA8617@bogus> (raw)
In-Reply-To: <20190520085846.22320-1-masneyb@onstation.org>
On Mon, 20 May 2019 04:58:46 -0400, Brian Masney wrote:
> The '#address-cells' and '#size-cells' properties were not defined in
> the lm3630a bindings and would cause the following error when
> attempting to validate the examples against the schema:
>
> Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml:
> '#address-cells', '#size-cells' do not match any of the regexes:
> '^led@[01]$', 'pinctrl-[0-9]+'
>
> Correct this by adding those two properties.
>
> While we're here, move the ti,linear-mapping-mode property to the
> led@[01] child nodes to correct the following validation error:
>
> Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml:
> led@0: 'ti,linear-mapping-mode' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>
> Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings")
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reported-by: Rob Herring <robh+dt@kernel.org>
> ---
> .../leds/backlight/lm3630a-backlight.yaml | 20 +++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2019-06-28 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:58 [PATCH] dt-bindings: backlight: lm3630a: correct schema validation Brian Masney
2019-05-20 13:14 ` Rob Herring
2019-05-20 13:30 ` Daniel Thompson
2019-05-22 0:53 ` Dan Murphy
2019-06-28 19:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628192238.GA8617@bogus \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonathan@marek.ca \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).